ChromeOS OOBE: replace $i18n with i18n-values in oobe_eula.html |
|||||||
Issue descriptionaria-labels in oobe_eula.html do not support language switching. $i18n needs to be replaced with i18n-values parameter.
,
Mar 22 2017
,
Mar 22 2017
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/893656ac30d6e0d8afef9d0ce458276effb36dff commit 893656ac30d6e0d8afef9d0ce458276effb36dff Author: alemate <alemate@chromium.org> Date: Thu Mar 23 01:27:12 2017 ChromeOS OOBE: replace i18n macro with i18n-values i18n macro doesn't support language switching, so we need to use i18n-values. BUG= 704028 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2767693003 Cr-Commit-Position: refs/heads/master@{#458970} [modify] https://crrev.com/893656ac30d6e0d8afef9d0ce458276effb36dff/chrome/browser/resources/chromeos/login/oobe_eula.html
,
Mar 23 2017
,
Mar 24 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be466fe8438ba3cee1958da07cb0944666b30536 commit be466fe8438ba3cee1958da07cb0944666b30536 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Mar 24 05:37:04 2017 ChromeOS OOBE: replace i18n macro with i18n-values i18n macro doesn't support language switching, so we need to use i18n-values. BUG= 704028 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2767693003 Cr-Commit-Position: refs/heads/master@{#458970} (cherry picked from commit 893656ac30d6e0d8afef9d0ce458276effb36dff) Review-Url: https://codereview.chromium.org/2775683003 . Cr-Commit-Position: refs/branch-heads/3029@{#403} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/be466fe8438ba3cee1958da07cb0944666b30536/chrome/browser/resources/chromeos/login/oobe_eula.html
,
May 24 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by alemate@chromium.org
, Mar 22 2017