New issue
Advanced search Search tips

Issue 704028 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 621719



Sign in to add a comment

ChromeOS OOBE: replace $i18n with i18n-values in oobe_eula.html

Project Member Reported by alemate@chromium.org, Mar 22 2017

Issue description

aria-labels in oobe_eula.html do not support language switching. $i18n needs to be replaced with i18n-values parameter.
 
Blocking: 621719
Description: Show this description
Summary: ChromeOS OOBE: replace $i18n with i18n-values in oobe_eula.html (was: ChromeOS OOBE: replace $i18n with i18n-content in oobe_eula.html)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/893656ac30d6e0d8afef9d0ce458276effb36dff

commit 893656ac30d6e0d8afef9d0ce458276effb36dff
Author: alemate <alemate@chromium.org>
Date: Thu Mar 23 01:27:12 2017

ChromeOS OOBE: replace i18n macro with i18n-values

i18n macro doesn't support language switching, so we need to use i18n-values.

BUG= 704028 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2767693003
Cr-Commit-Position: refs/heads/master@{#458970}

[modify] https://crrev.com/893656ac30d6e0d8afef9d0ce458276effb36dff/chrome/browser/resources/chromeos/login/oobe_eula.html

Labels: Merge-Request-58
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 24 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 24 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be466fe8438ba3cee1958da07cb0944666b30536

commit be466fe8438ba3cee1958da07cb0944666b30536
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Mar 24 05:37:04 2017

ChromeOS OOBE: replace i18n macro with i18n-values

i18n macro doesn't support language switching, so we need to use i18n-values.

BUG= 704028 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2767693003
Cr-Commit-Position: refs/heads/master@{#458970}
(cherry picked from commit 893656ac30d6e0d8afef9d0ce458276effb36dff)

Review-Url: https://codereview.chromium.org/2775683003 .
Cr-Commit-Position: refs/branch-heads/3029@{#403}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/be466fe8438ba3cee1958da07cb0944666b30536/chrome/browser/resources/chromeos/login/oobe_eula.html

Comment 8 by cda...@chromium.org, May 24 2017

Components: UI>Shell>OOBE UI>Shell>StartScreen

Sign in to add a comment