New issue
Advanced search Search tips

Issue 704021 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

webaudio/Oscillator/osc-custom-sweep-snr.html failing

Project Member Reported by horo@chromium.org, Mar 22 2017

Issue description

webaudio/Oscillator/osc-custom-sweep-snr.html failing

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/13783


https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__retina_/13783/layout-test-results/webaudio/Oscillator/osc-custom-sweep-snr-actual.txt

CONSOLE WARNING: line 79: Oscillator.frequency.exponentialRampToValue value 24050 outside nominal range [-22050, 22050]; value will be clamped.
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED. 
PASS > [test]  
FAIL X SNR is not greater than or equal to 93.45. Got 93.44996209025317. assert_true: expected true got false
PASS   Maximum difference is less than or equal to 0.00004. 
FAIL < [test] 1 out of 2 assertions were failed. assert_true: expected true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed. assert_true: expected true got false
Harness: the test ran to completion.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd641d3c73f24f48a5d0a66029b2fcd557f930ab

commit cd641d3c73f24f48a5d0a66029b2fcd557f930ab
Author: horo <horo@chromium.org>
Date: Wed Mar 22 07:04:21 2017

Revert of Allow status = 0 when XHR is completed in Audit.loadFileFromUrl(). (patchset #3 id:80001 of https://codereview.chromium.org/2766883002/ )

Reason for revert:
webaudio/Oscillator/osc-custom-sweep-snr.html is failing

See:  https://crbug.com/704021 

BUG= 704021 

Original issue's description:
> Allow status = 0 when XHR is completed in Audit.loadFileFromUrl().
>
> Currently Audit.loadFileFromUrl() checks the XHR status rigorously after
> its completion. This makes the XHR toward run-webkit-test server fail.
> To fix this issue, Audit.loadFileFromUrl() now accepts status = 0 in
> the |onload| handler.
>
> This change fixes the silent failure of XHR file fetching, thus enables
> some layout tests to do the actual buffer comparison within
> run-webkit-test.
>
> BUG= 701813 
> TEST=
> LayoutTests/webaudio/unit-tests/audit.html
> LayoutTests/webaudio/unit-tests/audit-failures.html
> LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html
> LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html
> LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html
> LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html
> LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
> LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html
>
> Review-Url: https://codereview.chromium.org/2766883002
> Cr-Commit-Position: refs/heads/master@{#458621}
> Committed: https://chromium.googlesource.com/chromium/src/+/709962cdd9abacd997ca1a884bbccefbcb43c1ad

TBR=rtoy@chromium.org,hongchan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 701813 

Review-Url: https://codereview.chromium.org/2768773002
Cr-Commit-Position: refs/heads/master@{#458654}

[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html
[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html
[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html
[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html
[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html
[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js
[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt
[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
[modify] https://crrev.com/cd641d3c73f24f48a5d0a66029b2fcd557f930ab/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html

Comment 2 by horo@chromium.org, Mar 22 2017

Labels: -Sheriff-Chromium
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba

commit a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba
Author: hongchan <hongchan@chromium.org>
Date: Wed Mar 22 16:26:30 2017

Allow status = 0 when XHR is completed in Audit.loadFileFromUrl().

Currently Audit.loadFileFromUrl() checks the XHR status rigorously after
its completion. This makes the XHR toward run-webkit-test server fail.
To fix this issue, Audit.loadFileFromUrl() now accepts status = 0 in
the |onload| handler.

This change fixes the silent failure of XHR file fetching, thus enables
some layout tests to do the actual buffer comparison within
run-webkit-test.

BUG= 701813 ,  704021 
TEST=
LayoutTests/webaudio/unit-tests/audit.html
LayoutTests/webaudio/unit-tests/audit-failures.html
LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html
LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html
LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html
LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html
LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html

Review-Url: https://codereview.chromium.org/2766883002
Cr-Original-Commit-Position: refs/heads/master@{#458621}
Committed: https://chromium.googlesource.com/chromium/src/+/709962cdd9abacd997ca1a884bbccefbcb43c1ad
Review-Url: https://codereview.chromium.org/2766883002
Cr-Commit-Position: refs/heads/master@{#458770}

[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html
[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html
[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html
[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html
[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html
[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js
[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt
[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
[modify] https://crrev.com/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html

Components: Blink>WebAudio
Labels: Test-Layout
Status: Verified (was: Assigned)

Sign in to add a comment