New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704012 link

Starred by 1 user
Status: Fixed
Owner:
█ sigbjo...@opera.com
Email to this user bounced
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

OfflineAudioContext doesn't always check ExecutionContext suspend state

Reported by sigbjo...@opera.com, Mar 22 2017 
A SuspendableObject implementation is required to call suspendIfNeeded() on a new instance, to synchronize execution context suspension state.

Not all OfflineAudioContext code paths do that, leading to an assert when these instances are finalized,

 https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__dbg_/7980/layout-test-results/webaudio/audiosummingjunction-crash-crash-log.txt
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c49908782266ac97dd687faf89ad10804db108b

commit 8c49908782266ac97dd687faf89ad10804db108b
Author: sigbjornf <sigbjornf@opera.com>
Date: Wed Mar 22 07:07:26 2017

OfflineAudioContext: add missing suspendIfNeeded() call.

R=haraken,rtoy
BUG= 704012 

Review-Url: https://codereview.chromium.org/2760323002
Cr-Commit-Position: refs/heads/master@{#458656}

[modify] https://crrev.com/8c49908782266ac97dd687faf89ad10804db108b/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp

Comment 2 by sigbjo...@opera.com, Mar 22 2017

Owner: sigbjo...@opera.com
Status: Fixed (was: Untriaged)
►

Sign in to add a comment