New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704008 link

Starred by 2 users
Status: Untriaged
Owner: ----
Cc:
tbuck...@chromium.org
bettes@chromium.org
█ dschuyler@chromium.org
steve...@chromium.org
sgabr...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 723078


Sign in to add a comment

Icon for encrypted wifi network does not match system menu

Project Member Reported by tbuck...@chromium.org, Mar 22 2017 
Lock icon should be dark gray, not light gray.

@sgabriel anything else?

Rationale for Pri-2: this is a minor consistency question. We should certainly address it, but it is unlikely to be noticed by many users.
Screenshot 2017-03-21 at 11.19.12 PM.png
25.0 KB View Download

Comment 1 by sgabr...@chromium.org, Mar 22 2017

Cc: -steve...@chromium.org sgabr...@chromium.org
Owner: steve...@chromium.org
It's also the wrong icon and the wrong size. Specs for this available here in the system menu iconography rule section: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZR34IMaWJcOe/files/MCH_EgKu0JgqhUhC2qR_m9-xwMSJbxAVNpw

Badges assets here:
https://drive.google.com/drive/folders/0B6x6iYCtKinEd2dPM0s4dmJ0RVU?usp=sharing

Comment 2 by steve...@chromium.org, Mar 22 2017

Labels: M-59

Comment 3 by tbuck...@chromium.org, Mar 22 2017

Description: Show this description

Comment 4 by steve...@chromium.org, Apr 12 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a83687c6c41879be7fb501972457d55bfe1ee2af

commit a83687c6c41879be7fb501972457d55bfe1ee2af
Author: stevenjb <stevenjb@chromium.org>
Date: Thu Apr 13 01:55:27 2017

MD Settings: Internet: Fix secure icon and badge colors

BUG=704008
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2813193003
Cr-Commit-Position: refs/heads/master@{#464240}

[modify] https://crrev.com/a83687c6c41879be7fb501972457d55bfe1ee2af/ui/webui/resources/cr_elements/network/cr_network_icon.html
[modify] https://crrev.com/a83687c6c41879be7fb501972457d55bfe1ee2af/ui/webui/resources/cr_elements/network/network_icons.html

Comment 6 by steve...@chromium.org, Apr 13 2017

Status: Fixed (was: Started)

Comment 7 by sdantul...@chromium.org, May 9 2017 

Lock icon size is not same as that in system menu.

Attached screenshot from TOT 9534.0.0, 60.0.3092.0

Please close if this is WAI.
Screenshot 2017-05-09 at 14.17.43.png
88.5 KB View Download

Comment 8 by sdantul...@chromium.org, May 9 2017

Status: Assigned (was: Fixed)

Comment 9 by steve...@chromium.org, May 9 2017

Labels: -M-59 M-60
Hrm, you're right the size is still off. I will take a look, but it's fine for 59 I think.

Comment 10 by steve...@chromium.org, May 16 2017

Blockedon: 723078

Comment 11 by steve...@chromium.org, May 16 2017

Labels: -M-60
In the System Tray which is Views based we use a different 2x asset for the lock icon which is smaller relative to the network icon than the 1x asset.

In Web UI we do not currently implement multiple icon sizes. This will be fixed when we address that (issue 723078).

Comment 12 by steve...@chromium.org, Jun 26 2017

Labels: M-62

Comment 13 by steve...@chromium.org, Aug 29 2017

Cc: dschuyler@chromium.org
Labels: -M-62

Comment 14 by steve...@chromium.org, Oct 31 2017

Cc: steve...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 15 by sheriffbot@chromium.org, Nov 1

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment