Hide incognito checkbox when no incognito windows are open |
|||
Issue descriptionWhen adding a content exception (eg. for cookies), the "Current incognito session only" checkbox is visible & disabled when no incognito windows are open. We should instead hide the checkbox. Rationale for Pri-2: disabled checkbox vs hidden checkbox is a very minor difference, this doesn't seem like something that will hurt the user experience.
,
Apr 1 2017
Could this be a Pri3?
,
Apr 3 2017
,
Apr 3 2017
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40e5b2648dda4c5f2766de6b34070cc54dd7e96d commit 40e5b2648dda4c5f2766de6b34070cc54dd7e96d Author: dschuyler <dschuyler@chromium.org> Date: Tue Apr 04 00:04:36 2017 [MD settings] hide for-current-incognito checkbox when incognito inactive This CL changes the checkbox about a content setting exception applying to the current incognito session. Instead of disabling the checkbox, the checkbox now becomes hidden. BUG= 704004 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2795873002 Cr-Commit-Position: refs/heads/master@{#461583} [modify] https://crrev.com/40e5b2648dda4c5f2766de6b34070cc54dd7e96d/chrome/browser/resources/settings/site_settings/add_site_dialog.html [modify] https://crrev.com/40e5b2648dda4c5f2766de6b34070cc54dd7e96d/chrome/browser/resources/settings/site_settings/add_site_dialog.js
,
Apr 4 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tbuck...@chromium.org
, Mar 22 2017