Cookie settings: tapping toggle labels has no effect |
||
Issue descriptionFor the first two toggle switches on the cookie settings page, tapping the label has no effect. However, clicking the label does trigger the toggle for the 3rd toggle.
,
Mar 31 2017
,
Mar 31 2017
Before and after shots (no changes).
,
Apr 1 2017
New after screen shot, showing the grey separator line again (so now, no changes).
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae7fc3094d50f04c513f4b62c5f45475cbba17f5 commit ae7fc3094d50f04c513f4b62c5f45475cbba17f5 Author: dschuyler <dschuyler@chromium.org> Date: Mon Apr 03 20:59:08 2017 [MD settings] clickable toggle labels on category default toggles This CL makes top level category default rows react to mouse clicks. These are the one or two rows at the top of a content settings category (such as "cookies"). The rows are toggles. Before this CL the labels on the toggles wouldn't act on mouse clicks when they should. Also, there are several name changes and tiddying up that could be in a separate CL if that is preferred. BUG= 704003 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2788853003 Cr-Commit-Position: refs/heads/master@{#461533} [modify] https://crrev.com/ae7fc3094d50f04c513f4b62c5f45475cbba17f5/chrome/browser/resources/settings/site_settings/category_default_setting.html [modify] https://crrev.com/ae7fc3094d50f04c513f4b62c5f45475cbba17f5/chrome/browser/resources/settings/site_settings/category_default_setting.js
,
Apr 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by dschuyler@chromium.org
, Mar 31 2017