New issue
Advanced search Search tips

Issue 703995 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Make table headers consistent & right contrast

Project Member Reported by tbuck...@chromium.org, Mar 22 2017

Issue description

Table headers on the Autofill subpage currently have contrast ratio is 2.7, recommended minimum is 4.5.

@bettes what values should be used?
 
Labels: -Pri-2 Pri-1
Summary: Make table headers consistent & right contrast (was: Table headers have low-contrast)
Updated title to reflect we also need to make table headers consistent. See Search engines list.

--paper-gray-600, medium bold
Cc: bettes@chromium.org
Owner: ----
Status: Available (was: Assigned)

Comment 4 by bettes@chromium.org, Mar 27 2017

Screen Shot 2017-03-27 at 3.29.11 PM.png
145 KB View Download
Labels: M-59

Comment 6 by dbeam@chromium.org, Mar 30 2017

Cc: -dbeam@chromium.org hcarmona@chromium.org dpa...@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/569fe6657d6887a1dab9e6476450ff403031832c

commit 569fe6657d6887a1dab9e6476450ff403031832c
Author: dbeam <dbeam@chromium.org>
Date: Thu Mar 30 23:32:09 2017

MD Settings: up contast of headers and other things that use grey 500 on white

BUG= 703995 
R=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2786113002
Cr-Commit-Position: refs/heads/master@{#460929}

[modify] https://crrev.com/569fe6657d6887a1dab9e6476450ff403031832c/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/569fe6657d6887a1dab9e6476450ff403031832c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html
[modify] https://crrev.com/569fe6657d6887a1dab9e6476450ff403031832c/chrome/browser/resources/settings/people_page/change_picture.html
[modify] https://crrev.com/569fe6657d6887a1dab9e6476450ff403031832c/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/569fe6657d6887a1dab9e6476450ff403031832c/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/569fe6657d6887a1dab9e6476450ff403031832c/chrome/browser/resources/settings/printing_page/cups_printers.html
[modify] https://crrev.com/569fe6657d6887a1dab9e6476450ff403031832c/chrome/browser/resources/settings/search_engines_page/search_engines_list.html
[modify] https://crrev.com/569fe6657d6887a1dab9e6476450ff403031832c/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/569fe6657d6887a1dab9e6476450ff403031832c/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/569fe6657d6887a1dab9e6476450ff403031832c/chrome/browser/resources/settings/site_settings/usb_devices.html

Comment 8 by dbeam@chromium.org, Mar 30 2017

Cc: dbeam@chromium.org
Owner: steve...@chromium.org
stevenjb@: there might be some lingering column headers on ChromeOS that I couldn't test.
Cc: steve...@chromium.org
Owner: dbeam@chromium.org
Status: Fixed (was: Started)
I can't think of any and didn't see any during a rough audit.

The cups changes look fine as far as I can tell.

Sign in to add a comment