New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703992 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Close button is unresponsive on 'Clear Browsing Data' overlay.

Reported by aiman.an...@etouch.net, Mar 22 2017

Issue description

Chrome Version: 59.0.3048.0 (Official Build) 1af111915f36842841682091b8c6882cae410831-refs/heads/master@{#458590}(32/64 Bit).

OS:  Windows(7,8,8.1,10).

Steps to reproduce:
1.Launch Chrome, go to chrome://history/ from wrench icon.
2.On chrome://history page, Click on Clear Browsing Data, on clear browsing data overlay click on close icon and observe.

Actual Result: Close button is unresponsive.
Expected Result: Close button should work.

This is regression issue broken in 'M 59' and will soon update the bisect info:

Manual Bisect Info: 
Good Build 59.0.3047.0
Bad Build 59.0.3048.0.

Note: Will soon update LINUX and MAC OS status once build #59.0.3048.0 is available.

 
Actual Result.mp4
694 KB View Download
Labels: OS-Linux OS-Mac
Issue also reproducible on Mac(10.11.6, 10.12.1, 10.12) and Linux(14.04 LTS) OS in build #59.0.3048.0

Note: Clear Browsing Data Overlay is unresponsive.
Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 59.0.3047.0 (Revision:458255).
Bad build:59.0.3048.0 (Revision:458590).

You are probably looking for a change made after 458526 (known good), but no later than 458527 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/2f746c5c4260329c7ef5a850ce1b72d78da106a6..f9e8f9e6d60d8cd26c4239a377419cbb37fe8724

@dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.

Comment 3 by dpa...@chromium.org, Mar 22 2017

Cc: tommycli@chromium.org
Status: Started (was: Assigned)
When the user navigates to the CBD dialog from the History page, the dialog forwards to a different URL (chrome://settings/advanced, see screenshot), which is not the case otherwise, when the user visits the CBD dialog from within MD Settings. I believe the bad URL is causing an endless recursion in tryTransitionToSection_ at https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settings_page/main_page_behavior.js?l=123.

@tommycli: Do you know why the CBD dialog behaves differently in those 2 cases? It seems to me that it should upon closing the dialog it should forward to chrome://md-settings in both cases.

Comment 4 by dpa...@chromium.org, Mar 22 2017

bad_url.png
91.0 KB View Download
Cc: dpa...@chromium.org
Owner: tommycli@chromium.org
Hey Demetrios,

I'll take this bug on (unless you want to). Thanks for the diagnosis.

Tommy
Owner: dpa...@chromium.org
Bouncing this back to dpapad, as I didn't realize this was intimately tied to the Advanced unbundling effort.

Comment 8 by dpa...@chromium.org, Mar 23 2017

Status: Fixed (was: Started)

Comment 9 by hdodda@chromium.org, Mar 28 2017

Cc: hdodda@chromium.org
Labels: TE-Verified-59.0.3053.3 TE-Veriifed-M59
Verified on Mac os 10.12.3 , ubuntu 14.04 and windows 7 using chrome M59 #59.0.3053.3 and issue is fixed.

Steps to verify:
1.Launch Chrome, go to chrome://history/ from wrench icon.
2.On chrome://history page, Click on Clear Browsing Data, on clear browsing data overlay click on close icon and observe.

close button works and clear browsing data overlay is disappeared/closed.

Attached screencast for reference.

Adding TE-Verified Labels.

Thanks!


703992.mp4
455 KB View Download

Sign in to add a comment