Regression: Close button is unresponsive on 'Clear Browsing Data' overlay.
Reported by
aiman.an...@etouch.net,
Mar 22 2017
|
|||||||
Issue descriptionChrome Version: 59.0.3048.0 (Official Build) 1af111915f36842841682091b8c6882cae410831-refs/heads/master@{#458590}(32/64 Bit). OS: Windows(7,8,8.1,10). Steps to reproduce: 1.Launch Chrome, go to chrome://history/ from wrench icon. 2.On chrome://history page, Click on Clear Browsing Data, on clear browsing data overlay click on close icon and observe. Actual Result: Close button is unresponsive. Expected Result: Close button should work. This is regression issue broken in 'M 59' and will soon update the bisect info: Manual Bisect Info: Good Build 59.0.3047.0 Bad Build 59.0.3048.0. Note: Will soon update LINUX and MAC OS status once build #59.0.3048.0 is available.
,
Mar 22 2017
Using the per-revision bisect providing the bisect results, Good build: 59.0.3047.0 (Revision:458255). Bad build:59.0.3048.0 (Revision:458590). You are probably looking for a change made after 458526 (known good), but no later than 458527 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/2f746c5c4260329c7ef5a850ce1b72d78da106a6..f9e8f9e6d60d8cd26c4239a377419cbb37fe8724 @dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You.
,
Mar 22 2017
When the user navigates to the CBD dialog from the History page, the dialog forwards to a different URL (chrome://settings/advanced, see screenshot), which is not the case otherwise, when the user visits the CBD dialog from within MD Settings. I believe the bad URL is causing an endless recursion in tryTransitionToSection_ at https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settings_page/main_page_behavior.js?l=123. @tommycli: Do you know why the CBD dialog behaves differently in those 2 cases? It seems to me that it should upon closing the dialog it should forward to chrome://md-settings in both cases.
,
Mar 22 2017
,
Mar 22 2017
Hey Demetrios, I'll take this bug on (unless you want to). Thanks for the diagnosis. Tommy
,
Mar 22 2017
Bouncing this back to dpapad, as I didn't realize this was intimately tied to the Advanced unbundling effort.
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd09b2036a499ad0be4d31a51898c33d20252878 commit bd09b2036a499ad0be4d31a51898c33d20252878 Author: dpapad <dpapad@chromium.org> Date: Wed Mar 22 20:55:08 2017 MD Settings: Fix endless recursion when exiting CBD dialog. BUG= 703992 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2763423002 Cr-Commit-Position: refs/heads/master@{#458871} [modify] https://crrev.com/bd09b2036a499ad0be4d31a51898c33d20252878/chrome/browser/resources/settings/route.js [modify] https://crrev.com/bd09b2036a499ad0be4d31a51898c33d20252878/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/bd09b2036a499ad0be4d31a51898c33d20252878/chrome/test/data/webui/settings/route_tests.js
,
Mar 23 2017
,
Mar 28 2017
Verified on Mac os 10.12.3 , ubuntu 14.04 and windows 7 using chrome M59 #59.0.3053.3 and issue is fixed. Steps to verify: 1.Launch Chrome, go to chrome://history/ from wrench icon. 2.On chrome://history page, Click on Clear Browsing Data, on clear browsing data overlay click on close icon and observe. close button works and clear browsing data overlay is disappeared/closed. Attached screencast for reference. Adding TE-Verified Labels. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by aiman.an...@etouch.net
, Mar 22 2017