Issue metadata
Sign in to add a comment
|
can't expand bundled notification in notification center |
||||||||||||||||||||||||
Issue descriptionWe can't expand a bundled notification by keyboard. Internal bug: b/36028068
,
Mar 27 2017
,
Mar 28 2017
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c787104b181d6ca1356c1f0b82257ed5a62ad633 commit c787104b181d6ca1356c1f0b82257ed5a62ad633 Author: yhanada <yhanada@chromium.org> Date: Tue Mar 28 11:54:49 2017 Extend notifications.mojom for expandable notifications. - Add |TOGGLE_EXPANSION| value to ArcNotificationEvent enum. - Add |expand_state| value to ArcNotificationData. BUG= 703989 Review-Url: https://codereview.chromium.org/2765923003 Cr-Commit-Position: refs/heads/master@{#460062} [modify] https://crrev.com/c787104b181d6ca1356c1f0b82257ed5a62ad633/components/arc/common/notifications.mojom [modify] https://crrev.com/c787104b181d6ca1356c1f0b82257ed5a62ad633/ui/arc/notification/arc_custom_notification_item.cc [modify] https://crrev.com/c787104b181d6ca1356c1f0b82257ed5a62ad633/ui/arc/notification/arc_custom_notification_item.h
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7af49bce7ecd2e79c8a54712d27bd45e27c2420 commit b7af49bce7ecd2e79c8a54712d27bd45e27c2420 Author: yhanada <yhanada@chromium.org> Date: Tue Mar 28 14:03:42 2017 Implement TOGGLE_EXPANSION action for the ARC notifications. TOGGLE_EXPANSION action will be triggerred when a user triggers DO_DEFAULT accessibility action on the notification. I use the target of the mouse pressing event on ArcCustomNotificationView to distinguish accessibility DO_DEFAULT action and normal click on the notification. This hack will be removed after making |AXActionData| be propagated to |HandleAccessibleAction|. BUG= 703989 Review-Url: https://codereview.chromium.org/2767253005 Cr-Commit-Position: refs/heads/master@{#460087} [modify] https://crrev.com/b7af49bce7ecd2e79c8a54712d27bd45e27c2420/ui/arc/notification/arc_custom_notification_view.cc [modify] https://crrev.com/b7af49bce7ecd2e79c8a54712d27bd45e27c2420/ui/arc/notification/arc_custom_notification_view.h [modify] https://crrev.com/b7af49bce7ecd2e79c8a54712d27bd45e27c2420/ui/arc/notification/arc_notification_item.cc [modify] https://crrev.com/b7af49bce7ecd2e79c8a54712d27bd45e27c2420/ui/arc/notification/arc_notification_item.h [modify] https://crrev.com/b7af49bce7ecd2e79c8a54712d27bd45e27c2420/ui/arc/notification/arc_notification_manager.cc [modify] https://crrev.com/b7af49bce7ecd2e79c8a54712d27bd45e27c2420/ui/arc/notification/arc_notification_manager.h [modify] https://crrev.com/b7af49bce7ecd2e79c8a54712d27bd45e27c2420/ui/message_center/views/custom_notification_view.cc [modify] https://crrev.com/b7af49bce7ecd2e79c8a54712d27bd45e27c2420/ui/message_center/views/custom_notification_view.h
,
Mar 31 2017
,
Mar 31 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d0f9e3fb82e37ac0bab42324165a2fb4dd636aa commit 0d0f9e3fb82e37ac0bab42324165a2fb4dd636aa Author: yhanada <yhanada@chromium.org> Date: Mon Apr 03 01:53:28 2017 Extend notifications.mojom for expandable notifications. - Add |TOGGLE_EXPANSION| value to ArcNotificationEvent enum. - Add |expand_state| value to ArcNotificationData. BUG= 703989 Review-Url: https://codereview.chromium.org/2765923003 Cr-Commit-Position: refs/heads/master@{#460062} (cherry picked from commit c787104b181d6ca1356c1f0b82257ed5a62ad633) Review-Url: https://codereview.chromium.org/2791903002 . Cr-Commit-Position: refs/branch-heads/3029@{#537} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/0d0f9e3fb82e37ac0bab42324165a2fb4dd636aa/components/arc/common/notifications.mojom [modify] https://crrev.com/0d0f9e3fb82e37ac0bab42324165a2fb4dd636aa/ui/arc/notification/arc_custom_notification_item.cc [modify] https://crrev.com/0d0f9e3fb82e37ac0bab42324165a2fb4dd636aa/ui/arc/notification/arc_custom_notification_item.h
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03873abfe51c7da3dd502d3addd309c1c1a74697 commit 03873abfe51c7da3dd502d3addd309c1c1a74697 Author: yhanada <yhanada@chromium.org> Date: Mon Apr 03 02:01:45 2017 Implement TOGGLE_EXPANSION action for the ARC notifications. TOGGLE_EXPANSION action will be triggerred when a user triggers DO_DEFAULT accessibility action on the notification. I use the target of the mouse pressing event on ArcCustomNotificationView to distinguish accessibility DO_DEFAULT action and normal click on the notification. This hack will be removed after making |AXActionData| be propagated to |HandleAccessibleAction|. BUG= 703989 Review-Url: https://codereview.chromium.org/2767253005 Cr-Commit-Position: refs/heads/master@{#460087} (cherry picked from commit b7af49bce7ecd2e79c8a54712d27bd45e27c2420) Review-Url: https://codereview.chromium.org/2793853002 . Cr-Commit-Position: refs/branch-heads/3029@{#538} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/03873abfe51c7da3dd502d3addd309c1c1a74697/ui/arc/notification/arc_custom_notification_view.cc [modify] https://crrev.com/03873abfe51c7da3dd502d3addd309c1c1a74697/ui/arc/notification/arc_custom_notification_view.h [modify] https://crrev.com/03873abfe51c7da3dd502d3addd309c1c1a74697/ui/arc/notification/arc_notification_item.cc [modify] https://crrev.com/03873abfe51c7da3dd502d3addd309c1c1a74697/ui/arc/notification/arc_notification_item.h [modify] https://crrev.com/03873abfe51c7da3dd502d3addd309c1c1a74697/ui/arc/notification/arc_notification_manager.cc [modify] https://crrev.com/03873abfe51c7da3dd502d3addd309c1c1a74697/ui/arc/notification/arc_notification_manager.h [modify] https://crrev.com/03873abfe51c7da3dd502d3addd309c1c1a74697/ui/message_center/views/custom_notification_view.cc [modify] https://crrev.com/03873abfe51c7da3dd502d3addd309c1c1a74697/ui/message_center/views/custom_notification_view.h
,
Apr 3 2017
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06ee0285ea203e11aca7161d8ea029f643f085ba commit 06ee0285ea203e11aca7161d8ea029f643f085ba Author: yhanada <yhanada@chromium.org> Date: Wed Apr 05 09:33:14 2017 Fix the check to distinguish accessibility events. BUG= 703989 TEST=Check that a mouse click on the expand button expands the notification and Ctrl+Space with ChromeVox on the notification expands/collapse the notification. Review-Url: https://codereview.chromium.org/2799573002 Cr-Commit-Position: refs/heads/master@{#462016} [modify] https://crrev.com/06ee0285ea203e11aca7161d8ea029f643f085ba/ui/arc/notification/arc_custom_notification_view.cc
,
Apr 5 2017
I request another merge to M-58.
,
Apr 6 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/facdf7ac09d0edb662402d08b9f66ab7ab78f0a8 commit facdf7ac09d0edb662402d08b9f66ab7ab78f0a8 Author: yhanada <yhanada@chromium.org> Date: Thu Apr 06 10:25:37 2017 Fix the check to distinguish accessibility events. BUG= 703989 TEST=Check that a mouse click on the expand button expands the notification and Ctrl+Space with ChromeVox on the notification expands/collapse the notification. Review-Url: https://codereview.chromium.org/2799573002 Cr-Commit-Position: refs/heads/master@{#462016} (cherry picked from commit 06ee0285ea203e11aca7161d8ea029f643f085ba) Review-Url: https://codereview.chromium.org/2805443003 . Cr-Commit-Position: refs/branch-heads/3029@{#602} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/facdf7ac09d0edb662402d08b9f66ab7ab78f0a8/ui/arc/notification/arc_custom_notification_view.cc
,
Apr 6 2017
,
May 11 2017
Chrome OS 9334.69.0, 58.0.3029.112 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by yhanada@chromium.org
, Mar 22 2017