New issue
Advanced search Search tips

Issue 703977 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Include translated language name in language settings

Project Member Reported by tbuck...@chromium.org, Mar 22 2017

Issue description

Old settings included the translated language name when adding a language (see screenshot), new settings only lists languages in the current language.
 
Screenshot 2017-03-21 at 7.50.30 PM.png
163 KB View Download

Comment 1 by dbeam@chromium.org, Mar 22 2017

Cc: dpa...@chromium.org michae...@chromium.org

Comment 2 by dpa...@chromium.org, Mar 27 2017

Owner: dpa...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7afee7ca97509175ccc5f31bc8082c964af0ad04

commit 7afee7ca97509175ccc5f31bc8082c964af0ad04
Author: dpapad <dpapad@chromium.org>
Date: Tue Mar 28 02:03:49 2017

MD Settings: Display languages native display name.

BUG= 703977 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2782493003
Cr-Commit-Position: refs/heads/master@{#459981}

[modify] https://crrev.com/7afee7ca97509175ccc5f31bc8082c964af0ad04/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/7afee7ca97509175ccc5f31bc8082c964af0ad04/chrome/browser/resources/settings/languages_page/add_languages_dialog.js

Comment 4 by dpa...@chromium.org, Mar 28 2017

Status: Fixed (was: Started)

Comment 5 by dbeam@chromium.org, Mar 30 2017

Status: Started (was: Fixed)
please correct this issue then mark Fixed
Screen Shot 2017-03-31 at 1.08.49 AM.png
36.2 KB View Download

Comment 6 by dpa...@chromium.org, Mar 30 2017

I was planning to file a separate bug for this, but I can just keep this one open instead, if you prefer.

The original bug though was a P1. Do you think that the remaining task is also a P1?

Comment 7 by dpa...@chromium.org, Mar 30 2017

Minimal repro case at https://jsfiddle.net/3o0tdowt/2/.

Commenting out line at [1] fixes the issue (but may cause other weirdness?). I am not sure yet whether there is a bug in the string that we receive from the chrome.languageSettingsPrivate API, or if the bug is in paper-checkbox. Also the strings are exactly the same between old and new Settings, but old Settings puts them inside an <option> tag, which seems to not have the problem.

[1] https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/paper-checkbox/paper-checkbox.html?l=185
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf1cb4ef559d87d9814200e9005437c3643a57cb

commit cf1cb4ef559d87d9814200e9005437c3643a57cb
Author: dpapad <dpapad@chromium.org>
Date: Fri Mar 31 21:10:43 2017

MD Settings: Fix native languge name wrapping.

BUG= 703977 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2786313006
Cr-Commit-Position: refs/heads/master@{#461230}

[modify] https://crrev.com/cf1cb4ef559d87d9814200e9005437c3643a57cb/chrome/browser/resources/settings/languages_page/add_languages_dialog.html

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Chrome OS 9532.0.0, 60.0.3092.0

Sign in to add a comment