New issue
Advanced search Search tips

Issue 703970 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 697700



Sign in to add a comment

Move Bluetooth.Web.FunctionCall.Count UMA from browser to WebKit

Project Member Reported by juncai@chromium.org, Mar 22 2017

Issue description

Based on the comment at:
https://codereview.chromium.org/2752663002/diff/140001/content/browser/bluetooth/web_bluetooth_service_impl.cc

Moving Bluetooth.Web.FunctionCall.Count UMA from browser to WebKit makes sense since those UMA counts the function calls on the renderer side.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63c7ac485b91957bd4fb2a1ff743cbf43f526717

commit 63c7ac485b91957bd4fb2a1ff743cbf43f526717
Author: juncai <juncai@chromium.org>
Date: Fri Mar 31 04:52:57 2017

Move Bluetooth.Web.FunctionCall.Count UMA from browser to WebKit

Based on the discussion:
https://codereview.chromium.org/2752663002/diff/140001/content/browser/bluetooth/web_bluetooth_service_impl.cc

UMAWebBluetoothFunction::REMOTE_GATT_SERVER_DISCONNECT UMA was intended
to count how often JavaScript called disconnect, but with the change of
the above CL, it also counts when the device disconnects and the
browser is informed, or for any other reason when the client is
disconnected. So we think moving Bluetooth.Web.FunctionCall.Count UMA
from browser to WebKit makes sense since those UMA counts the function
calls on the renderer side.

BUG= 703970 

Review-Url: https://codereview.chromium.org/2771893002
Cr-Commit-Position: refs/heads/master@{#461038}

[modify] https://crrev.com/63c7ac485b91957bd4fb2a1ff743cbf43f526717/content/browser/bluetooth/bluetooth_metrics.cc
[modify] https://crrev.com/63c7ac485b91957bd4fb2a1ff743cbf43f526717/content/browser/bluetooth/bluetooth_metrics.h
[modify] https://crrev.com/63c7ac485b91957bd4fb2a1ff743cbf43f526717/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/63c7ac485b91957bd4fb2a1ff743cbf43f526717/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/63c7ac485b91957bd4fb2a1ff743cbf43f526717/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl
[modify] https://crrev.com/63c7ac485b91957bd4fb2a1ff743cbf43f526717/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.idl
[modify] https://crrev.com/63c7ac485b91957bd4fb2a1ff743cbf43f526717/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.idl
[modify] https://crrev.com/63c7ac485b91957bd4fb2a1ff743cbf43f526717/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.idl
[modify] https://crrev.com/63c7ac485b91957bd4fb2a1ff743cbf43f526717/tools/metrics/histograms/histograms.xml

Comment 2 by juncai@chromium.org, Mar 31 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27217b8880dcd75b1b22e98275ea0dab4663454e

commit 27217b8880dcd75b1b22e98275ea0dab4663454e
Author: scheib <scheib@chromium.org>
Date: Wed May 10 06:05:49 2017

Mark BluetoothDeviceConnectGATT UMA enum obsolete.

BUG= 703970 

Review-Url: https://codereview.chromium.org/2865403004
Cr-Commit-Position: refs/heads/master@{#470495}

[modify] https://crrev.com/27217b8880dcd75b1b22e98275ea0dab4663454e/tools/metrics/histograms/enums.xml

Sign in to add a comment