We've definitely had failures in pixel-based tests between different Macs. I can try my Mac and see if this particular issue happens.

It turns out I haven't used my Mac in several months and it's broken in many ways. It's also not running 10.12, so I'm not very helpful here.

npm@ these looks like the tests you've been adding. Can you build on 10.12 on your mac and get new digest numbers for them?

I guess we'll need to do something smart in the test to ifdef on the version of mac we're dealing with? Or we'll need to do the upgrade at the same time the hashes are committed.

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/5bcd9a32232e8cd5df918104eb131be76f833701

commit 5bcd9a32232e8cd5df918104eb131be76f833701
Author: Nicolas Pena <npm@chromium.org>
Date: Wed Mar 22 15:35:34 2017

Fix Mac tests on 10.12

md5's with text are changed, so need to allow both the previous and the new one.
Pixel tests with text also fail on 10.12, so suppressing those.
Found many unexpected successes, so will unsuppress those once all bots are 10.12

BUG= chromium:703912 

Change-Id: I6b34aa2f581eb8ea705f3876960b49c89e249347
Reviewed-on: https://pdfium-review.googlesource.com/3144
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>

[modify] https://crrev.com/5bcd9a32232e8cd5df918104eb131be76f833701/testing/embedder_test.cpp
[modify] https://crrev.com/5bcd9a32232e8cd5df918104eb131be76f833701/testing/SUPPRESSIONS
[modify] https://crrev.com/5bcd9a32232e8cd5df918104eb131be76f833701/fpdfsdk/fpdfedit_embeddertest.cpp
[modify] https://crrev.com/5bcd9a32232e8cd5df918104eb131be76f833701/testing/embedder_test.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a120e2da4ebe4db41406b7b1477d2575afc2eb20

commit a120e2da4ebe4db41406b7b1477d2575afc2eb20
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Wed Mar 22 16:45:18 2017

Roll src/third_party/pdfium/ 742fa8c3b..5bcd9a322 (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/742fa8c3b39f..5bcd9a32232e

$ git log 742fa8c3b..5bcd9a322 --date=short --no-merges --format='%ad %ae %s'
2017-03-22 npm Fix Mac tests on 10.12

Created with:
  roll-dep src/third_party/pdfium
BUG= 703912 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2768823002
Cr-Commit-Position: refs/heads/master@{#458777}

[modify] https://crrev.com/a120e2da4ebe4db41406b7b1477d2575afc2eb20/DEPS

Please reopen if you still get test failures on upgraded bots.

I upgraded my Mac and it's happy. So I hope the upgrade goes smoothly. Please let us know when the upgrade finishes, so we can remove the test expectations for 10.9.

dba: BTW, is there a bug for upgrading the PDFium Macs that we can follow? Are you going to upgrade our trybots too at the same time? They all say 10.9.5 currently.

https://build.chromium.org/p/client.pdfium/buildslaves/vm24-m3
https://build.chromium.org/p/client.pdfium/buildslaves/vm25-m3
https://build.chromium.org/p/client.pdfium/buildslaves/vm635-m3

https://build.chromium.org/p/tryserver.client.pdfium/buildslaves/vm154-m4
https://build.chromium.org/p/tryserver.client.pdfium/buildslaves/vm200-m4

I can do them at the same time. I'll just track the updates here seeing as all the interested parties are already on this bug.

We have a master 10.12 upgrade bug (issue 659213), but I still need to create the child tickets to track upgrade process for the wider audiences. The main bug kind of a mess, and erikchen@ and I have just been corresponding via email as I've started doing some spot upgrades as tests now that we've been seemingly unblocked.

If you want to upgrade them soon, today even, please go ahead. I think it will be really helpful to have the developer machines and bots on the same version of OS X, as we have found differences in pixel tests due to the OS mismatch.

I'll go ahead and start on this then.

Thanks. Hope it goes smoothly.

vm{24,25,635}-m3 and vm{154,200}-m4 are all now 10.12. So far everything looks green.

Still green over the weekend, gonna mark this as fixed.

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/0d6d1783ed96ae25cf5d0fb83d13ba1e7421a6cd

commit 0d6d1783ed96ae25cf5d0fb83d13ba1e7421a6cd
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Mar 27 14:47:23 2017

Remove old test expectations after the Mac 10.12 upgrade.

BUG= chromium:703912 

Change-Id: I5b4e582afc95b845e8e5e7a4e14581127c18de2d
Reviewed-on: https://pdfium-review.googlesource.com/3193
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>

[modify] https://crrev.com/0d6d1783ed96ae25cf5d0fb83d13ba1e7421a6cd/testing/embedder_test.cpp
[modify] https://crrev.com/0d6d1783ed96ae25cf5d0fb83d13ba1e7421a6cd/core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp
[modify] https://crrev.com/0d6d1783ed96ae25cf5d0fb83d13ba1e7421a6cd/fpdfsdk/fpdfedit_embeddertest.cpp
[modify] https://crrev.com/0d6d1783ed96ae25cf5d0fb83d13ba1e7421a6cd/testing/embedder_test.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02177c7ab2602bac1fa9f2dfdc9421b70a4c3f46

commit 02177c7ab2602bac1fa9f2dfdc9421b70a4c3f46
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Mon Mar 27 17:06:01 2017

Roll src/third_party/pdfium/ 2977e1e34..0d6d1783e (6 commits)

https://pdfium.googlesource.com/pdfium.git/+log/2977e1e342a1..0d6d1783ed96

$ git log 2977e1e34..0d6d1783e --date=short --no-merges --format='%ad %ae %s'
2017-03-24 thestig Remove old test expectations after the Mac 10.12 upgrade.
2017-03-23 adenilson.cavalcanti Update to zlib 1.2.11
2017-03-24 caryclark fix new tab crash in skia clip stack
2017-03-24 tsepez kill another CFX_ArrayTemplate in cfde_txtedtengine.cpp
2017-03-24 tsepez Use std::vector in fxfa/app.
2017-03-24 stephana Ensure empty output directory to avoid duplicate upload

Created with:
  roll-dep src/third_party/pdfium
BUG= 703912 , 687631 , 704442 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2779673002
Cr-Commit-Position: refs/heads/master@{#459805}

[modify] https://crrev.com/02177c7ab2602bac1fa9f2dfdc9421b70a4c3f46/DEPS