New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703895 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Regressions in handling ARC shelf item in case of multiple apps.

Project Member Reported by khmel@chromium.org, Mar 22 2017

Issue description

First regression is in the case of multiple shelf items for the same ARC app, clicking on shelf item always activates last opened window. It is expected that in this case last active window of that app becomes active. Second one, selecting which item to activate from menu does not actually activate selected item.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a19209825989de7d6b620aea95dd0f95b5c3c03f

commit a19209825989de7d6b620aea95dd0f95b5c3c03f
Author: khmel <khmel@chromium.org>
Date: Wed Mar 22 05:21:55 2017

arc: Fix regression in handling ARC shelf item.

This fix regressions caused by recent refactoring. First regression is
in case multiple shelf items for the same ARC app, clicking on shelf
item always activates last opened window. It is expected that in this
case last active window of that app becomes active. Second one,
selecting which item to activate from menu does not actually activate
selected item

BUG= 703895 
TEST=Manually, unit_tests extended.

Review-Url: https://codereview.chromium.org/2763893004
Cr-Commit-Position: refs/heads/master@{#458638}

[modify] https://crrev.com/a19209825989de7d6b620aea95dd0f95b5c3c03f/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/a19209825989de7d6b620aea95dd0f95b5c3c03f/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
[modify] https://crrev.com/a19209825989de7d6b620aea95dd0f95b5c3c03f/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.h
[modify] https://crrev.com/a19209825989de7d6b620aea95dd0f95b5c3c03f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Comment 2 by khmel@chromium.org, Mar 22 2017

Cc: bhthompson@chromium.org
Labels: Merge-Request-58
Labels: -Merge-Request-58 Merge-Approved-58
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e62cb970ec7675219a52e1f529136335fc95970d

commit e62cb970ec7675219a52e1f529136335fc95970d
Author: khmel <khmel@chromium.org>
Date: Thu Mar 23 01:45:10 2017

[Merge M58] arc: Fix regression in handling ARC shelf item.

This fix regressions caused by recent refactoring. First regression is
in case multiple shelf items for the same ARC app, clicking on shelf
item always activates last opened window. It is expected that in this
case last active window of that app becomes active. Second one,
selecting which item to activate from menu does not actually activate
selected item

BUG= 703895 
TEST=Manually, unit_tests extended.
NOTRY=true
NOPRESUBMIT=true
TBR=msw@chromium.org

Review-Url: https://codereview.chromium.org/2763893004
Cr-Commit-Position: refs/heads/master@{#458638}
(cherry picked from commit a19209825989de7d6b620aea95dd0f95b5c3c03f)

Review-Url: https://codereview.chromium.org/2773493002
Cr-Commit-Position: refs/branch-heads/3029@{#377}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/e62cb970ec7675219a52e1f529136335fc95970d/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/e62cb970ec7675219a52e1f529136335fc95970d/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
[modify] https://crrev.com/e62cb970ec7675219a52e1f529136335fc95970d/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.h
[modify] https://crrev.com/e62cb970ec7675219a52e1f529136335fc95970d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Comment 5 by khmel@chromium.org, Mar 23 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
58.0.3029.36/9334.20.0

Sign in to add a comment