New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703894 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 524758

Blocking:
issue 713180



Sign in to add a comment

Move remaining local blink tests to run on swarming and use analyze

Project Member Reported by tansell@chromium.org, Mar 22 2017

Issue description

Currently "BlinkTests" run under the following conditions;
----------------------
CHROMIUM_BLINK_TESTS_BUILDERS = freeze([
  'linux_chromium_rel_ng',
  'mac_chromium_rel_ng',
  'win_chromium_rel_ng',
])


CHROMIUM_BLINK_TESTS_PATHS = freeze([
  'components/test_runner',
  'content/browser/bluetooth',
  'content/browser/service_worker',
  'content/child/service_worker',
  'content/common/bluetooth',
  'content/renderer/bluetooth',
  'content/renderer/service_worker',
  'content/shell/browser/layout_test',
  'content/shell/renderer/layout_test',
  'device/bluetooth',
  'device/usb/public/interfaces',
  'media',
  'third_party/WebKit',
  'third_party/harfbuzz-ng',
  'third_party/iccjpeg',
  'third_party/libjpeg',
  'third_party/libjpeg_turbo',
  'third_party/libpng',
  'third_party/libwebp',
  'third_party/qcms',
  'third_party/skia',
  'third_party/yasm',
  'third_party/zlib',
  'v8',
])
----------------------

When these match the following things are added;

----------------------
    # Add blink tests that work well with "analyze" here. The tricky ones
    # that bypass it (like the layout tests) are added later.
    if add_blink_tests:
      add_tests([
          self.steps.GTestTest('blink_heap_unittests'),
          self.steps.GTestTest('blink_platform_unittests'),
          self.steps.GTestTest('webkit_unit_tests'),
          self.steps.GTestTest('wtf_unittests'),
      ])
----------------------
      if add_blink_tests:
        blink_tests = [
            self.steps.ScriptTest(
                'webkit_lint', 'webkit_lint.py', collections.defaultdict(list)),
            self.steps.ScriptTest(
                'webkit_python_tests', 'webkit_python_tests.py',
                collections.defaultdict(list)),
        ]
        add_tests(blink_tests)
        for test in blink_tests:
          compile_targets.extend(test.compile_targets(self._api_for_tests))
        compile_targets = sorted(set(compile_targets))
----------------------

 
Blockedon: 524758
Cc: qyears...@chromium.org
Status: Available (was: Untriaged)
Note, BlinkTests is also run when it's explicitly listed in the chromium_tests builders config dict (e.g. https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py).

This bug is not about those, right? Just about doing whatever is necessary to remove that `add_blink_tests` logic in ChromiumTestsApi._trybot_steps_internal (https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?l=975), right?
Correct, this is just the targets which are not layout tests but still get included here.
Cc: jochen@chromium.org tansell@chromium.org
 Issue 709933  has been merged into this issue.
Owner: mcgreevy@chromium.org
Status: Started (was: Available)
Assigning to mcgreevy as he is looking into this for layout tests.
Blocking: 713180
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa07565e88d7bf456ece9dc4cf2673b7aad656dc

commit aa07565e88d7bf456ece9dc4cf2673b7aad656dc
Author: danakj <danakj@chromium.org>
Date: Fri Apr 28 14:46:49 2017

Add blink unit tests to the linux/mac/windows builders.

This will run the unit test suites for the try bots and on the main
chromium waterfall. Once this is done, we can remove them from the
separate webkit waterfall.

R=dpranke@chromium.org
BUG= 713180 ,  703894 

Review-Url: https://codereview.chromium.org/2849673002
Cr-Commit-Position: refs/heads/master@{#467993}

[modify] https://crrev.com/aa07565e88d7bf456ece9dc4cf2673b7aad656dc/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/aa07565e88d7bf456ece9dc4cf2673b7aad656dc/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/aa07565e88d7bf456ece9dc4cf2673b7aad656dc/testing/buildbot/chromium.win.json

Project Member

Comment 8 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ff03caced30e039dd5e90ee265f8a8cd4490018d

commit ff03caced30e039dd5e90ee265f8a8cd4490018d
Author: danakj <danakj@chromium.org>
Date: Mon May 01 04:02:25 2017

Remove gtests from the webkit waterfall.

These tests should run as part of the usual chromium win/mac/linux
builders instead, so they can run on all CLs that affect them as
determined by analyze.

R=dpranke@chromium.org

Bug:  713180 , 703894 
Change-Id: Ib16178babaa74a43f05e6dc4511a00b5fcee1e32
Reviewed-on: https://chromium-review.googlesource.com/489447
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>

[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/blink_linux.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_that_fails.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipes/chromium_trybot.expected/add_layout_tests_via_manual_diff_inspection.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/blink_mac.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json

With danakj's changes in  https://crbug.com/713180  we are now down to these two;
------------------
       blink_tests = [
            self.steps.ScriptTest(
                'webkit_lint', 'webkit_lint.py', collections.defaultdict(list)),
            self.steps.ScriptTest(
                'webkit_python_tests', 'webkit_python_tests.py',
                collections.defaultdict(list)),
        ]
------------------

(As well as LayoutTests, but that is being worked on and will be fixed as that is rolled out on swarming everywhere and on all CLs.)
Project Member

Comment 10 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/09b8f2f7f2de95dc3515487a32fa330667265e20

commit 09b8f2f7f2de95dc3515487a32fa330667265e20
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Thu May 04 00:43:03 2017

Simplify code which controls adding swarmed or local layout tests.

Bug:703894
Change-Id: I64c6ae6304b41e429365a4d97bb6486e1e762c3a
Reviewed-on: https://chromium-review.googlesource.com/489224
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>

[modify] https://crrev.com/09b8f2f7f2de95dc3515487a32fa330667265e20/scripts/slave/recipe_modules/chromium_tests/api.py

Project Member

Comment 11 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/59b248f278e4828bbb0a8d8685975856a7f60509

commit 59b248f278e4828bbb0a8d8685975856a7f60509
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Mon May 08 05:17:30 2017

Stop manually adding webkit_layout_tests if it's already configured src-side.

Bug:703894

Change-Id: If54e6c2705c6dc95c8f59a6f3d174c0780c511bf
Reviewed-on: https://chromium-review.googlesource.com/490592
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/59b248f278e4828bbb0a8d8685975856a7f60509/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/59b248f278e4828bbb0a8d8685975856a7f60509/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.py

Issue 723019 has been merged into this issue.
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9630e8fd9711768152d1505cccd5708a322895f4

commit 9630e8fd9711768152d1505cccd5708a322895f4
Author: mcgreevy <mcgreevy@chromium.org>
Date: Mon Jun 05 03:24:59 2017

src-side config for runing layout tests on all affected cls on Linux

BUG= 703894 

Review-Url: https://codereview.chromium.org/2866673002
Cr-Commit-Position: refs/heads/master@{#476933}

[modify] https://crrev.com/9630e8fd9711768152d1505cccd5708a322895f4/testing/buildbot/chromium.linux.json

Owner: tansell@chromium.org
Summary: Move remaining local blink tests to run on swarming and use analyze (was: Move all the current "BlinkTests" from explicit running, to analyze based running)
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48d4f56053dec8d56dd0a1caa1fb253ebba3b8ec

commit 48d4f56053dec8d56dd0a1caa1fb253ebba3b8ec
Author: tansell <tansell@chromium.org>
Date: Tue Jun 13 12:21:46 2017

chromium.webkit: Run Layout Tests on Swarming (on Linux bots).

Converts the WebKit waterfall bots to run layout tests on swarming.

Land https://crrev.com/c/526534 for the recipe side change after this CL lands.

BUG= 703894 , 524758 
NOTRY=true

Review-Url: https://codereview.chromium.org/2924713004
Cr-Commit-Position: refs/heads/master@{#478980}

[modify] https://crrev.com/48d4f56053dec8d56dd0a1caa1fb253ebba3b8ec/testing/buildbot/chromium.webkit.json

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ae8e680460dd0c2ce98da659e0839000ded0d23

commit 3ae8e680460dd0c2ce98da659e0839000ded0d23
Author: tansell <tansell@chromium.org>
Date: Tue Jun 13 13:31:06 2017

Revert of chromium.webkit: Run Layout Tests on Swarming (on Linux bots). (patchset #3 id:40001 of https://codereview.chromium.org/2924713004/ )

Reason for revert:
The extra test expectation files needed by the bots are not included in the isolate (or not referenced correctly).

https://chromium-swarm.appspot.com/task?id=36ba424f86833510&refresh=10&request_detail=true&show_raw=1

05:33:12.601 15501 additional_expectations path 'src/third_party/WebKit/LayoutTests/LeakExpectations' does not exist

Original issue's description:
> chromium.webkit: Run Layout Tests on Swarming (on Linux bots).
>
> Converts the WebKit waterfall bots to run layout tests on swarming.
>
> Land https://crrev.com/c/526534 for the recipe side change after this CL lands.
>
> BUG= 703894 , 524758 
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2924713004
> Cr-Commit-Position: refs/heads/master@{#478980}
> Committed: https://chromium.googlesource.com/chromium/src/+/48d4f56053dec8d56dd0a1caa1fb253ebba3b8ec

TBR=dpranke@chromium.org,mcgreevy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 703894 , 524758 

Review-Url: https://codereview.chromium.org/2936763004
Cr-Commit-Position: refs/heads/master@{#478997}

[modify] https://crrev.com/3ae8e680460dd0c2ce98da659e0839000ded0d23/testing/buildbot/chromium.webkit.json

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87486756658e0131876b8694b6a25ad1110dd50d

commit 87486756658e0131876b8694b6a25ad1110dd50d
Author: tansell <tansell@chromium.org>
Date: Wed Jun 14 06:54:00 2017

chromium.webkit: Run Layout Tests on Swarming (on Linux bots).

Converts the WebKit waterfall bots to run layout tests on swarming.

Land https://crrev.com/c/526534 for the recipe side change after this CL lands.

BUG= 703894 , 524758 
NOTRY=true

Review-Url: https://codereview.chromium.org/2924713004
Cr-Commit-Position: refs/heads/master@{#479309}

[modify] https://crrev.com/87486756658e0131876b8694b6a25ad1110dd50d/testing/buildbot/chromium.webkit.json

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/dee2d8e1a57320cd3e32818b6817d9fa371c392e

commit dee2d8e1a57320cd3e32818b6817d9fa371c392e
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Wed Jun 14 08:42:47 2017

chromium.webkit: Run Layout Tests on Swarming (on Linux bots).

Converts the WebKit waterfall bots to run layout tests on swarming.

Land *after* src side configuration in https://crrev.com/2924713004 has
been landed.

BUG= 703894 ,  524758 

Change-Id: I3a769e58fa02401266ea978bef4c1674409491e4
Reviewed-on: https://chromium-review.googlesource.com/526534
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[delete] https://crrev.com/f8641bd71040be4a16b2e8b3ef1492ff9d97313c/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_with_and_without_patch_fail.json
[modify] https://crrev.com/dee2d8e1a57320cd3e32818b6817d9fa371c392e/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_webkit.json
[delete] https://crrev.com/f8641bd71040be4a16b2e8b3ef1492ff9d97313c/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/dee2d8e1a57320cd3e32818b6817d9fa371c392e/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py
[delete] https://crrev.com/f8641bd71040be4a16b2e8b3ef1492ff9d97313c/scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json
[modify] https://crrev.com/dee2d8e1a57320cd3e32818b6817d9fa371c392e/scripts/slave/recipe_modules/test_utils/test_api.py
[delete] https://crrev.com/f8641bd71040be4a16b2e8b3ef1492ff9d97313c/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_unexpected_error.json
[delete] https://crrev.com/f8641bd71040be4a16b2e8b3ef1492ff9d97313c/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_minimal_pass_continues.json
[modify] https://crrev.com/dee2d8e1a57320cd3e32818b6817d9fa371c392e/scripts/slave/recipes/chromium.py
[delete] https://crrev.com/f8641bd71040be4a16b2e8b3ef1492ff9d97313c/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_interrupted.json
[delete] https://crrev.com/f8641bd71040be4a16b2e8b3ef1492ff9d97313c/scripts/slave/recipes/chromium.expected/chromium_webkit_warnings.json
[modify] https://crrev.com/dee2d8e1a57320cd3e32818b6817d9fa371c392e/scripts/slave/recipes/chromium_trybot.py
[delete] https://crrev.com/f8641bd71040be4a16b2e8b3ef1492ff9d97313c/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_compile_without_patch_fails.json
[modify] https://crrev.com/dee2d8e1a57320cd3e32818b6817d9fa371c392e/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_chromium.json
[delete] https://crrev.com/f8641bd71040be4a16b2e8b3ef1492ff9d97313c/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot_test_failures.json

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaf4b270e7509fb7563c0e905c88f3a2dc2cd6d9

commit aaf4b270e7509fb7563c0e905c88f3a2dc2cd6d9
Author: tansell <tansell@chromium.org>
Date: Wed Jun 14 12:07:21 2017

chromium.webkit: Fix WebKit Linux Trusty (dbg) builder.

The debug builder has stuff in out/Debug not out/Release so we need the
--debug flag.

BUG= 703894 , 524758 
TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2936193002
Cr-Commit-Position: refs/heads/master@{#479354}

[modify] https://crrev.com/aaf4b270e7509fb7563c0e905c88f3a2dc2cd6d9/testing/buildbot/chromium.webkit.json

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0e77f3ab4c7cee01a67302da149d889e61099ea

commit c0e77f3ab4c7cee01a67302da149d889e61099ea
Author: tansell <tansell@chromium.org>
Date: Wed Jun 14 12:35:44 2017

Revert of chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. (patchset #1 id:1 of https://codereview.chromium.org/2936193002/ )

Reason for revert:
The --debug argument is in the wrong place.

Original issue's description:
> chromium.webkit: Fix WebKit Linux Trusty (dbg) builder.
>
> The debug builder has stuff in out/Debug not out/Release so we need the
> --debug flag.
>
> BUG= 703894 , 524758 
> TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2936193002
> Cr-Commit-Position: refs/heads/master@{#479354}
> Committed: https://chromium.googlesource.com/chromium/src/+/aaf4b270e7509fb7563c0e905c88f3a2dc2cd6d9

TBR=dpranke@chromium.org,mcgreevy@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 703894 , 524758 

Review-Url: https://codereview.chromium.org/2940843002
Cr-Commit-Position: refs/heads/master@{#479358}

[modify] https://crrev.com/c0e77f3ab4c7cee01a67302da149d889e61099ea/testing/buildbot/chromium.webkit.json

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9f6c4e0459c41bbcc70eaa3aac9d1edfbeff3d5

commit a9f6c4e0459c41bbcc70eaa3aac9d1edfbeff3d5
Author: tansell <tansell@chromium.org>
Date: Wed Jun 14 12:46:13 2017

chromium.webkit: Fix WebKit Linux Trusty MSAN builder.

Each shard currently takes more than 1 hour to run, so we need to
increase the default 1 hour swarming timeout value.

BUG= 703894 , 524758 
TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2939913002
Cr-Commit-Position: refs/heads/master@{#479360}

[modify] https://crrev.com/a9f6c4e0459c41bbcc70eaa3aac9d1edfbeff3d5/testing/buildbot/chromium.webkit.json

Project Member

Comment 23 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d3829dc61cf018cbab6ddf57a0d77180d47b034

commit 5d3829dc61cf018cbab6ddf57a0d77180d47b034
Author: tansell <tansell@chromium.org>
Date: Wed Jun 14 12:47:56 2017

chromium.webkit: Fix WebKit Linux Trusty (dbg) builder.

The debug builder has stuff in out/Debug not out/Release so we need the
--debug flag.

Now the --debug argument is in the right place!

BUG= 703894 , 524758 
TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2936193002
Cr-Commit-Position: refs/heads/master@{#479362}

[modify] https://crrev.com/5d3829dc61cf018cbab6ddf57a0d77180d47b034/testing/buildbot/chromium.webkit.json

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6760b0fbac2dc3f8a1e74909388b4f53a58bba3b

commit 6760b0fbac2dc3f8a1e74909388b4f53a58bba3b
Author: tansell <tansell@chromium.org>
Date: Wed Jun 14 15:19:22 2017

chromium.webkit: Fix WebKit Linux Trusty MSAN builder.

Each shard currently takes more than 1 hour to run, so we need to
increase the default 1 hour swarming timeout value.

Now editing the right bot config!

BUG= 703894 , 524758 
TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2939913002
Cr-Commit-Position: refs/heads/master@{#479390}

[modify] https://crrev.com/6760b0fbac2dc3f8a1e74909388b4f53a58bba3b/testing/buildbot/chromium.webkit.json

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbfa94edc35a58fac121884f5b3a668ee34ed670

commit bbfa94edc35a58fac121884f5b3a668ee34ed670
Author: tansell <tansell@chromium.org>
Date: Thu Jun 15 03:30:18 2017

chromium.webkit: Fix WebKit Linux Trusty (dbg) builder.

In https://codereview.chromium.org/2939913002/ the number of shards
was accidently removed, causing on a single shard to be used.

A single shard takes longer than an hour, so it times out causing
failure.

With 6 shards, it takes about 45 minutes to run.

BUG= 703894 , 524758 , 732891 
TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2940053002
Cr-Commit-Position: refs/heads/master@{#479592}

[modify] https://crrev.com/bbfa94edc35a58fac121884f5b3a668ee34ed670/testing/buildbot/chromium.webkit.json

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51a69bcf539116e6d8ab573dc9ca263a61023ec2

commit 51a69bcf539116e6d8ab573dc9ca263a61023ec2
Author: tansell <tansell@chromium.org>
Date: Thu Jun 15 04:42:31 2017

chromium.webkit: Adjust shard numbers for <1h cycle times.

 * 'WebKit Linux Trusty ASAN' currently takes ~2.5 hrs
 * 'WebKit Linux Trusty MSAN' currently takes ~6 hrs
 * 'WebKit Linux Trusty Leak' currently takes ~1 hrs
 * 'WebKit Linux Trusty (dbg)' currently takes ~3.5 hrs

BUG= 703894 , 524758 
NOTRY=true

Review-Url: https://codereview.chromium.org/2938783002
Cr-Commit-Position: refs/heads/master@{#479604}

[modify] https://crrev.com/51a69bcf539116e6d8ab573dc9ca263a61023ec2/testing/buildbot/chromium.webkit.json

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b36032776688471227ab1ebd9cb21faeb8e9bf4

commit 2b36032776688471227ab1ebd9cb21faeb8e9bf4
Author: tansell <tansell@chromium.org>
Date: Fri Jun 16 06:09:47 2017

chromium.fyi: Run Layout Tests on Swarming (on Linux bots).

Converts most of the Linux FYI bots to run layout tests on swarming.

Land https://crrev.com/c/532499 for the recipe side change after this CL lands.

BUG= 703894 , 524758 
NOTRY=true

Review-Url: https://codereview.chromium.org/2927703002
Cr-Commit-Position: refs/heads/master@{#479964}

[modify] https://crrev.com/2b36032776688471227ab1ebd9cb21faeb8e9bf4/testing/buildbot/chromium.fyi.json

Project Member

Comment 28 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ac8a36558294c122de0090306caf0d76e4bf0f99

commit ac8a36558294c122de0090306caf0d76e4bf0f99
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Fri Jun 16 07:35:46 2017

chromium.fyi: Run Layout Tests on Swarming (on Linux bots).

Converts the Linux FYI waterfall bots to run layout tests on swarming.

Land *after* src side configuration in https://crrev.com/2927703002 has
been landed.

BUG= 703894 ,  524758 

Change-Id: Iaef8c1fd1cbdcd5d4ab60a4b5886df6f619dc344
Reviewed-on: https://chromium-review.googlesource.com/532499
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/ac8a36558294c122de0090306caf0d76e4bf0f99/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f1e290b35df9f831824a1d51f5fe3f5395e2a7e

commit 2f1e290b35df9f831824a1d51f5fe3f5395e2a7e
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Thu Aug 17 04:24:13 2017

buildbot: Move remaining webkit scripts to JSON config.

These two scripts are currently still configured in BlinkTest, see;
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?l=1022

Once these tests are running via the .json file we can remove them from
BlinkTest.

BUG= 524758 , 703894 
R=qyearsley@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,jeffcarp@chromium.org
NOTRY=true

Change-Id: I689436e4e6fb0e4ba109101f9bd3690bf3cfcca9
Reviewed-on: https://chromium-review.googlesource.com/611501
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495071}
[modify] https://crrev.com/2f1e290b35df9f831824a1d51f5fe3f5395e2a7e/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/2f1e290b35df9f831824a1d51f5fe3f5395e2a7e/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/2f1e290b35df9f831824a1d51f5fe3f5395e2a7e/testing/buildbot/chromium.win.json

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/02cc9cfee42d7b927427f874431b11dc6af6df03

commit 02cc9cfee42d7b927427f874431b11dc6af6df03
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Sun Aug 20 23:41:37 2017

chromium_tests: Remove scripts which have been added via .json file.

These scripts were added via .json file in;
https://chromium.googlesource.com/chromium/src.git/+/2f1e290b35df9f831824a1d51f5fe3f5395e2a7e

BUG= 524758 , 703894 
R=qyearsley@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,jeffcarp@chromium.org

Change-Id: Iebcac4c17a8ae89c9aaebac8f12e2f79b61eedaf
Reviewed-on: https://chromium-review.googlesource.com/622009
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>

[modify] https://crrev.com/02cc9cfee42d7b927427f874431b11dc6af6df03/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/blink_linux.json
[modify] https://crrev.com/02cc9cfee42d7b927427f874431b11dc6af6df03/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_that_fails.json
[modify] https://crrev.com/02cc9cfee42d7b927427f874431b11dc6af6df03/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection.json
[modify] https://crrev.com/02cc9cfee42d7b927427f874431b11dc6af6df03/scripts/slave/recipes/chromium_trybot.expected/add_layout_tests_via_manual_diff_inspection.json
[modify] https://crrev.com/02cc9cfee42d7b927427f874431b11dc6af6df03/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/02cc9cfee42d7b927427f874431b11dc6af6df03/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/02cc9cfee42d7b927427f874431b11dc6af6df03/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
[modify] https://crrev.com/02cc9cfee42d7b927427f874431b11dc6af6df03/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/blink_mac.json
[modify] https://crrev.com/02cc9cfee42d7b927427f874431b11dc6af6df03/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json

Status: Fixed (was: Started)
This is now fixed!

The only thing left to be finished is Layout Tests and that is progressing as I post this.

Sign in to add a comment