New issue
Advanced search Search tips

Issue 703890 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make Crashpad run_tests.py work with paths instead of configuration names

Project Member Reported by mark@chromium.org, Mar 21 2017

Issue description

I’ve been trying to share a source tree between different platforms, using gyp_crashpad.py --generator-output to put the build output in the right place. On Windows, it winds up in out\win\out\{Debug,Release}{,_x64}. This makes it tricky to use run_tests.py, which expects to find build output right in the “out” directory. It’s not impossible to use, because you can tell it “win\out\Debug_x64”, but it’s really awkward to use that path when we all know that it’s not relative to anything that makes sense, like the current directory.

This will require:

1. A Crashpad-side change to change how run_tests.py works.
2. A Buildbot slave recipe change to invoke run_tests.py in the new way.
3. A master restart? Not sure.
4. Something else? Not sure.

I’m filing this bug to have something to point to in case the third and fourth items become necessary.
 

Comment 1 by mark@chromium.org, Mar 22 2017

Owner: mark@chromium.org
Status: Started (was: Untriaged)
1. Crashpad side: https://chromium-review.googlesource.com/457716/
2. Buildbot slave recipe: https://chromium-review.googlesource.com/457736/
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/47899c1186474197f5fe8d17390b8d6299f89fee

commit 47899c1186474197f5fe8d17390b8d6299f89fee
Author: Mark Mentovai <mark@chromium.org>
Date: Wed Mar 22 01:28:43 2017

crashpad: Make tests work with paths instead of configuration names

This is co-dependent with
https://chromium-review.googlesource.com/457716.

BUG= chromium:703890 

Change-Id: I09468687cca81518628d2a81820129ba0acee559
Reviewed-on: https://chromium-review.googlesource.com/457736
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/47899c1186474197f5fe8d17390b8d6299f89fee/scripts/slave/recipes/crashpad/build.expected/crashpad_try_win_x86_wow64_dbg.json
[modify] https://crrev.com/47899c1186474197f5fe8d17390b8d6299f89fee/scripts/slave/recipes/crashpad/build.expected/crashpad_mac_dbg.json
[modify] https://crrev.com/47899c1186474197f5fe8d17390b8d6299f89fee/scripts/slave/recipes/crashpad/build.expected/crashpad_win_x64_rel.json
[modify] https://crrev.com/47899c1186474197f5fe8d17390b8d6299f89fee/scripts/slave/recipes/crashpad/build.expected/crashpad_try_win_x64_dbg.json
[modify] https://crrev.com/47899c1186474197f5fe8d17390b8d6299f89fee/scripts/slave/recipes/crashpad/build.expected/crashpad_win_x86_wow64_rel.json
[modify] https://crrev.com/47899c1186474197f5fe8d17390b8d6299f89fee/scripts/slave/recipes/crashpad/build.expected/crashpad_try_mac_rel.json
[modify] https://crrev.com/47899c1186474197f5fe8d17390b8d6299f89fee/scripts/slave/recipes/crashpad/build.py
[modify] https://crrev.com/47899c1186474197f5fe8d17390b8d6299f89fee/scripts/slave/recipes/crashpad/build.expected/crashpad_mac_dbg_clobber.json
[modify] https://crrev.com/47899c1186474197f5fe8d17390b8d6299f89fee/scripts/slave/recipes/crashpad/build.expected/crashpad_try_win_x86_rel.json
[modify] https://crrev.com/47899c1186474197f5fe8d17390b8d6299f89fee/scripts/slave/recipes/crashpad/build.expected/crashpad_win_x86_dbg.json

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/39f13a77a44969f0e51208ecbc9246fcc93be583

commit 39f13a77a44969f0e51208ecbc9246fcc93be583
Author: Mark Mentovai <mark@chromium.org>
Date: Wed Mar 22 01:45:16 2017

Make run_tests.py work with paths instead of configuration names

This is co-dependent with
https://chromium-review.googlesource.com/457736.

I’ve been trying to share a source tree between different platforms,
using gyp_crashpad.py --generator-output to put the build output in the
right place. On Windows, it winds up in
out\win\out\{Debug,Release}{,_x64}. This makes it tricky to use
run_tests.py, which expects to find build output right in the “out”
directory. It’s not impossible to use, because you can tell it
“win\out\Debug_x64”, but it’s really awkward to use that path when we
all know that it’s not relative to anything that makes sense, like the
current directory.

This simplifies run_tests.py to work directly with the
configuration-specific output directory. For most users, this means
including “out/” or “out\” when running the script.

Bug:  chromium:703890 
Change-Id: Ic7de82fabd2adda7ae00558844cb3ce91aa4a5ed
Reviewed-on: https://chromium-review.googlesource.com/457716
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/39f13a77a44969f0e51208ecbc9246fcc93be583/build/run_tests.py
[modify] https://crrev.com/39f13a77a44969f0e51208ecbc9246fcc93be583/doc/developing.md

Comment 4 by mark@chromium.org, Mar 22 2017

Status: Fixed (was: Started)
Looks like it took only the two steps I knew about.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a53e839bbe97b3936efad635e8feed3551cf545

commit 2a53e839bbe97b3936efad635e8feed3551cf545
Author: mark <mark@chromium.org>
Date: Thu Mar 23 22:06:41 2017

Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

3eaee58970c2 doc: Update Android developer documentation for NDK 14
87c75552ad70 Implement ProcessInfo for Linux/Android
bad4fd00113a linux: Fix ProcessInfo for x86[_64]
48781dc182c2 linux: Fix process start time computation
9be4745be0f7 linux: Lazily initialize ProcessInfo’s Is64Bit() and
             StartTime()
d7467ba7e485 linux: Use user_regs instead of pt_regs for 32-bit ARM in
             ProcessInfo
5938c6e9933a linux: Support ProcessInfo::Is64Bit() for ARM on pre-3.5.0
             Linux
82009cd14de5 android: Support builds with NDK API versions older than 21
             (compat)
b10d9118dea4 minidump: Ignore attempts to add user streams with type
             collisions
51b21d887467 Add DelimitedFileReader and use it in Linux/Android’s
             ProcessInfo
00b64427523b Make file_io reads more rational and predictable
4f90f1514692 Remove WeakStdioFileReader and WeakStdioFileWriter
88bc09fb8615 posix: Fix StdioFileHandle() for GCC
14138936b5c4 test: Compare ProcessInfo::Arguments() to main()’s
             argc/argv on POSIX
bc5b7b06db68 Fix racy WorkerThread test
542306626df8 minidump: Make the MemoryListStream the caboose once again
39f13a77a449 Make run_tests.py work with paths instead of configuration
             names
3983b80ca2fc util/file: Handle oversized reads and writes gracefully
e4cad9e51483 doc: Standardize on “macOS” in comments
c1157e87f164 Crashpad overview design doc
af66c4b74028 Add overview design doc link to root README.md
cca10659c739 android: Fix gmock-using tests’ use of MOCK_METHODn()
             with clang
db8c54e142d9 android: Add gyp_crashpad_android.py for easier Android
             development
013d5e14a30c #include <stddef.h> where offsetof() is used
7a7815506bf2 GCC fix: Don’t use arraysize() on packed structs
fa3413e14a22 GCC fix for -Wunused-but-set-variable
810d4815df8a minidump: Allow for user extension streams computed at
             crash time
cedfd7b9cd71 android: Don’t use OPEN_MAX
f8ef834ef5dd android: Support “unified headers” with GCC build
8e37886d418d linux: Don’t make assumptions about the CPU revision

BUG=crashpad:30,  crashpad:167 , crashpad:169,  crashpad:171 ,  chromium:703890 

Review-Url: https://codereview.chromium.org/2773813002
Cr-Commit-Position: refs/heads/master@{#459244}

[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/build/secondary/third_party/crashpad/crashpad/minidump/BUILD.gn
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/README.chromium
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/README.md
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/build/gyp_crashpad.py
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/build/gyp_crashpad_android.py
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/build/run_tests.py
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/client/client_test.gyp
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/client/crash_report_database_win.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/client/settings.cc
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/compat/android/elf.h
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/compat/android/linux/ptrace.h
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/compat/compat.gyp
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/doc/developing.md
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/doc/layering.png
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/doc/overview.png
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/doc/overview_design.md
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/handler/win/crash_other_program.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump.gyp
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_crashpad_info_writer_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_file_writer.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_file_writer.h
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_file_writer_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_memory_writer_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_misc_info_writer_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_module_writer.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_module_writer_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_system_info_writer_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_test.gyp
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_unloaded_module_writer_test.cc
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_user_extension_stream_data_source.cc
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_user_extension_stream_data_source.h
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_user_stream_writer.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_user_stream_writer.h
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/minidump_user_stream_writer_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/minidump/test/minidump_writable_test_util.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/api/module_annotations_win_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/cpu_context.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/cpu_context_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/mac/cpu_context_mac.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.h
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/mac/process_reader.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/mac/process_reader.h
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.h
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/snapshot_test.gyp
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/win/cpu_context_win.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_extra_memory_ranges.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_simple_annotations.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/win/extra_memory_ranges_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/win/pe_image_annotations_reader_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/win/pe_image_reader.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/win/process_reader_win_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win_test.cc
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/test/gmock_main.cc
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/test/gtest_main.cc
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/test/main_arguments.cc
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/test/main_arguments.h
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/test/main_arguments_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/test/multiprocess_exec_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/test/multiprocess_posix_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/test/test.gyp
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/test/test_test.gyp
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/test/win/win_child_process.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/third_party/gtest/gmock.gyp
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/tools/crashpad_database_util.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/tools/crashpad_http_upload.cc
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/delimited_file_reader.cc
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/delimited_file_reader.h
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/delimited_file_reader_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/file_io.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/file_io.h
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/file_io_posix.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/file_io_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/file_io_win.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/file_reader.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/file_reader.h
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/file_reader_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/file_writer.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/file/file_writer.h
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/mach/child_port_handshake.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/mach/exception_ports_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/mach/mach_message_server_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/mach/notify_server_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/misc/uuid.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/net/http_transport_libcurl.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/net/http_transport_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/posix/close_multiple.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/posix/process_info.h
[add] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/posix/process_info_linux.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/posix/process_info_mac.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/posix/process_info_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/thread/worker_thread_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/util.gyp
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/util_test.gyp
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/win/process_info.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/win/process_info_test.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/win/registration_protocol_win.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/win/scoped_process_suspend.cc
[modify] https://crrev.com/2a53e839bbe97b3936efad635e8feed3551cf545/third_party/crashpad/crashpad/util/win/scoped_process_suspend_test.cc

Sign in to add a comment