Test coverage for GpuProcessTransportFactory |
||||||||||
Issue descriptionA recent change to GpuProcessTransportFactory has broken several features including Display Mirror Mode and Unified Desktop Mode (see issue 702713 ). That could be prevented if there was at least some test coverage for this class. Consider refactoring this code to make at least some parts of it testable.
,
Apr 10 2017
,
Apr 10 2017
+rjkroege@, sadrul@, kylechar@, staraz@, samans@. we are currently working on what will become a major refactor of GpuProcessTransportFactory to use MojoFrameSinkManager. Along the way we should be increasing test coverage. Hopefully that addresses this bug.
,
Apr 17 2017
Assigning to kylechar@: Please add unit tests for FrameSinkManagerHost as you add functionality to it. I think that would address this bug.
,
Apr 19 2017
,
May 3 2017
,
May 23 2017
,
Jun 13 2017
GpuProcessTransportFactory will be going away in the viz code path, so I'm marking this bug as Available and removing it as a blocker.
,
Jun 13 2017
,
Jun 13 2017
GpuProcessTransportFactory is half CommandLine reading and half interesting logic. The lesson here when we recreate it is, I think: Put command line reading outside the class, and pass things into it instead, much like LayerTreeSettings. This will allow us to instantiate it in tests and test the more interesting things like shared context loss/recovery. So: ban CommandLine reading in classes with logic.
,
Feb 26 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by vmi...@chromium.org
, Apr 8 2017Status: Available (was: Untriaged)