New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 703854 link

Starred by 2 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
gov...@chromium.org
pbomm...@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Command+L/Command+T is broken in full scren mode

Project Member Reported by pxia@google.com, Mar 21 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.98 Safari/537.36

Steps to reproduce the problem:
1. go full screen
2. hit Command+T/L

What is the expected behavior?
UI should focus on the address bar to allow user to type

What went wrong?
unable to type (the entire top bar flashes and disappears)

Did this work before? Yes 

Chrome version: 57.0.2987.98  Channel: stable
OS Version: OS X 10.12.3
Flash Version:

Comment 1 by durga.behera@chromium.org, Mar 22 2017

Cc: pbomm...@chromium.org ranjitkan@chromium.org gov...@chromium.org
Components: -UI UI>Browser>FullScreen
Labels: ReleaseBlock-Stable M-57
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.3 using 57.0.2987.98/110.

Bisect info:
------------
Good:57.0.2987.21/57.0.2986.0/57.0.2987.0/57.0.2988.0
Bad :57.0.2987.54/89/110

Its broken in 2987 branch, hence unable to run the bisect using the Depot-tool, suspecting the below from Omahaproxy UI CL.
https://chromium.googlesource.com/chromium/src/+log/57.0.2987.21..57.0.2987.54?pretty=fuller&n=10000
Review-Url: https://codereview.chromium.org/2671073002
spqchan@: Could you please take a look into this if its related to your change.
Added Releaseblock-Stable as its broken in M57 branch only and working fine on 58.0.3029.19(beta) and canary 59.0.3048.0.

Comment 2 by durga.behera@chromium.org, Mar 22 2017 

Note: This is not applicable to Win and Linux.

Comment 3 by gov...@chromium.org, Mar 22 2017 

Related  bug 689115 .

Comment 4 by spqc...@chromium.org, Mar 22 2017 

The fix is here and it was merged to M58:
https://chromium.googlesource.com/chromium/src.git/+/e86cff1a78d3b1f75b454487afee3101d3504519

I can merge it to M57

Comment 5 by gov...@chromium.org, Mar 22 2017 

How is the change looking in Canary/Dev and Beta? Will it be a safe merge to M57?

Comment 6 by spqc...@chromium.org, Mar 22 2017 

The change looks fine, so far it has not caused any regressions

Comment 7 by spqc...@chromium.org, Mar 22 2017

Labels: Merge-Request-57

Comment 8 by gov...@chromium.org, Mar 22 2017 

Approving merge to M57 branch 2987 based on comment #6 (Note: Initially we decided not to take this merge in  bug 689115  but there are multiple reports and per comment #6 change is safe and looking good in M58 beta).

Comment 9 by gov...@chromium.org, Mar 22 2017

Labels: -Merge-Request-57 Merge-Approved-57

Comment 10 by spqc...@chromium.org, Mar 22 2017

Status: Fixed (was: Assigned)

Comment 11 by gov...@chromium.org, Mar 22 2017

Labels: -Merge-Approved-57 merge-merged-2987
It is already merged ot M57 - https://chromium.googlesource.com/chromium/src.git/+/692ba2ee806a7680085c51c383e722744b7f1e61
►

Sign in to add a comment