r298410 | erichkeane | 2017-03-21 13:49:17 -0400 (Tue, 21 Mar 2017) | 11 lines

Correct class-template deprecation behavior

Based on the comment in the test, and my reading of the standard, a deprecated warning should be issued in the following case:
template<typename T> [[deprecated]] class Foo{}; Foo<int> f;

This was not the case, because the ClassTemplateSpecializationDecl creation did not also copy the deprecated attribute.

Note: I did NOT audit the complete set of attributes to see WHICH ones should be copied, so instead I simply copy ONLY the deprecated attribute.

Differential Revision: https://reviews.llvm.org/D27486




E.g. https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/7819

FAILED: obj/third_party/swiftshader/src/OpenGL/compiler/preprocessor/swiftshader_opengl_preprocessor/Preprocessor.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/swiftshader/src/OpenGL/compiler/preprocessor/swiftshader_opengl_preprocessor/Preprocessor.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"298422\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DLOG_TAG=\"swiftshader_opengl_compiler\" -I../.. -Igen -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -m64 -march=x86-64 -pthread -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -O2 -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../third_party/swiftshader/src/OpenGL/compiler/preprocessor/Preprocessor.cpp -o obj/third_party/swiftshader/src/OpenGL/compiler/preprocessor/swiftshader_opengl_preprocessor/Preprocessor.o
In file included from ../../third_party/swiftshader/src/OpenGL/compiler/preprocessor/Preprocessor.cpp:23:
../../third_party/swiftshader/src/OpenGL/compiler/preprocessor/MacroExpander.h:78:7: error: 'auto_ptr<pp::Token>' is deprecated [-Werror,-Wdeprecated-declarations]
        std::auto_ptr<Token> mReserveToken;
             ^
../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/backward/auto_ptr.h:281:7: note: 'auto_ptr<pp::Token>' has been explicitly marked deprecated here
    } _GLIBCXX_DEPRECATED;
      ^
../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/x86_64-linux-gnu/bits/c++config.h:84:46: note: expanded from macro '_GLIBCXX_DEPRECATED'
# define _GLIBCXX_DEPRECATED __attribute__ ((__deprecated__))
                                             ^


capn, can you make swiftshader use unique_ptr instead?

Alternatively, please add -Wno-deprecated-declarations to your cflags (examples: https://cs.chromium.org/search/?q=wno-deprecated-decla+package:%5Echromium$&type=cs)