New issue
Advanced search Search tips

Issue 703849 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 703331



Sign in to add a comment

Fix duplicate testnames in WebAudio layout tests

Project Member Reported by rtoy@chromium.org, Mar 21 2017

Issue description

There are many tests in webaudio that have duplicated test harness test names (because the names are generated by Audit).

Fix these because  issue 703331  will make them errors.
 

Comment 1 by rtoy@chromium.org, Mar 22 2017

Blocking: 703331
Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85

commit 1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85
Author: rtoy <rtoy@chromium.org>
Date: Wed Mar 22 23:05:21 2017

Fix duplicate test names in WebAudio tests

Testharness prints errors about duplicate test names.  Fix up these
duplicate names.  For the most part, the minimum change was done to
remove the duplicate test names.  However, a few tests did a little
bit more to make the resulting output "nice" because the changes were
simple.

To verify these, apply the patch from crrev.com/2766823003 and run
tests locally.  No tests fail.  Without the patch, you can't tell from
run-webkit-tests if anything is still broken.

BUG= 703849 
TEST=

Review-Url: https://codereview.chromium.org/2768983002
Cr-Commit-Position: refs/heads/master@{#458918}

[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/Analyser/handle-silent-inputs.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-copy-channel.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-clamp-time-to-current-time.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-continuous.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/ConstantSource/constant-source-basic.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/ConstantSource/constant-source-output.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-constructor.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/onstatechange.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-basic.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/Panner/panner-distance-clamping.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-panning.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/audionodeoptions.js
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/channelmerger.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/delay.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/dynamicscompressor.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/gain.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/panner.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/constructor/waveshaper.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/mixing.html
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/resources/audit-util.js
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/resources/merger-testing.js
[modify] https://crrev.com/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85/third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js

Comment 3 by rtoy@chromium.org, Mar 23 2017

Status: Fixed (was: Started)

Sign in to add a comment