Eliminate veyron_pinky from the PFQ |
||||||||
Issue descriptionWe currently have both veryon_pinky and veron_minnie chrome configurations in the PFQ (and a veryon_jerry chromium configuration). veyron_pinky does not run HWTests appears to be entirely redundant, we should remove it.
,
Mar 21 2017
We have veyron_pinky-paladin in the CQ, but no hwtests. So I'm mostly ok with this. I'm especially OK with this if we determine that we can remove veyron_pinky-paladin from the CQ as well. +snanda@ anyone who owns veyron_pinky want to speak up?
,
Mar 21 2017
The veyron bots have different configuration options for Chrome because of the video requirements. Look for v4l_plugin and v4l_coder (one is rockchip, the other is tegra IIRC).
,
Mar 21 2017
oops s/v4l_coder/v4l_codec/
,
Mar 21 2017
OK, well if veyron_pinky-paladin has chrome useflags that are only satisfied by veyron_pinky-chrome-pfq then this is indeed a no-go. This is what BinhostTest exists to protect us against, so you can always create the CL and try. If it fails BinhostTest, you'll know why.
,
Mar 21 2017
> OK, well if veyron_pinky-paladin has chrome useflags > that are only satisfied by veyron_pinky-chrome-pfq > then this is indeed a no-go. veyron_pinky is a reference board; there's no hardware, and no product. Assuming that the use flags are applicable to veyron generally, we should transfer the work being done for pinky to some existing veyron builder. If only pinky depends on those useflags, we should delete all the pinky builders.
,
Mar 22 2017
Re comment #3 - could you clarify where we should be looking for v4l references? I found some references to v4l2_codec through codesearch, but nothing in the overlays.
binhost_test passes and without the change (i.e. current ToT) it specifically identifies veyron_minne and veyron_pinky as being identical:
The following Chrome PFQs produce identical prebuilts: _BoardKey(board='veyron_minnie', useflags=('chrome_internal',)), _BoardKey(board='veyron_pinky', useflags=('chrome_internal',)) -- _CompatId(arch='arm', useflags=('accessibility', 'autotest', 'build_tests', 'buildcheck', 'chrome_debug', 'chrome_internal', 'chrome_remoting', 'clang', 'cups', 'evdev_gestures', 'fonts', 'gold', 'hardfp', 'highdpi', 'nacl', 'neon', 'opengles', 'ozone_platform_default_gbm', 'ozone_platform_gbm', 'runhooks', 'v4l2_codec', 'v4lplugin', 'xkbcommon'), cflags=('-O2', '-O2', '-pipe', '-mcpu=cortex-a12', '-mtune=cortex-a12', '-mfpu=neon', '-mfloat-abi=hard', '-g', '-fno-exceptions', '-fno-unwind-tables', '-fno-asynchronous-unwind-tables'))
CL: https://chromium-review.googlesource.com/c/457622/
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f7987154749cb576d4c1b639483e5a6da668d35d commit f7987154749cb576d4c1b639483e5a6da668d35d Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Mar 22 06:15:09 2017 chromeos_config.py: Remove veyron_pinky from chrome_pfq_important_boards veyron_pinky is redundant with veyron_minnie. BUG= chromium:703841 TEST=./cbuildbot/chromeos_config_unittest Change-Id: I62848694e8ad38ff9efd49703374bcb60fa0e1eb Reviewed-on: https://chromium-review.googlesource.com/457622 Commit-Ready: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/f7987154749cb576d4c1b639483e5a6da668d35d/cbuildbot/config_dump.json [modify] https://crrev.com/f7987154749cb576d4c1b639483e5a6da668d35d/cbuildbot/waterfall_layout_dump.txt [modify] https://crrev.com/f7987154749cb576d4c1b639483e5a6da668d35d/cbuildbot/chromeos_config.py
,
Mar 22 2017
,
Mar 22 2017
,
May 30 2017
,
Aug 1 2017
,
Aug 3 2017
Closing. Please reopen it if its not fixed. Thanks! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by steve...@chromium.org
, Mar 21 2017