New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 703839 link

Starred by 1 user
Status: Fixed
Owner:
tbarzic@chromium.org
Closed: Apr 2017
Cc:
█ bfetscher@google.com
rdevlin....@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

networkingPrivate: Connection failure automatically pops up system dialog asking for user credentials

Project Member Reported by tbarzic@chromium.org, Mar 21 2017 
In case of connection failure on Chrome OS, networkingPrivate.startConnect method will reroute error handling to NetworkConnect::MaybeShowConfigureUI:
https://cs.chromium.org/chromium/src/extensions/browser/api/networking_private/networking_private_chromeos.cc?rcl=52d3120f703a3cbb61042a1e5957f69c5cb94329&l=857

While this somewhat makes sense for calls from network settings UI, this behavior is undesirable in kiosk, and should be fixed.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70efae18e35db3dd25e00c2dfc205b7a3b72e76e

commit 70efae18e35db3dd25e00c2dfc205b7a3b72e76e
Author: tbarzic <tbarzic@chromium.org>
Date: Wed Apr 12 20:01:27 2017

Don't show network config UI when networkingPrivate.startConenct fails

If networkingPrivate.startConnect fails the API should not attempt showing
network configuration dialog (as it currently does for certain errors, e.g.
when the network passphrase is wrong). The API should let clients handle
the error themselves. Plus it makes expectations about network connection
state after startConnect returns clearer.

The behaviour is kept only for requests from web ui context, as network
config UI on Chrome OS still depends on this behavior.

BUG= 703839 

Review-Url: https://codereview.chromium.org/2814023002
Cr-Commit-Position: refs/heads/master@{#464123}

[modify] https://crrev.com/70efae18e35db3dd25e00c2dfc205b7a3b72e76e/extensions/browser/api/networking_private/networking_private_api.cc
[modify] https://crrev.com/70efae18e35db3dd25e00c2dfc205b7a3b72e76e/extensions/browser/api/networking_private/networking_private_api.h
[modify] https://crrev.com/70efae18e35db3dd25e00c2dfc205b7a3b72e76e/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/70efae18e35db3dd25e00c2dfc205b7a3b72e76e/extensions/browser/api/networking_private/networking_private_chromeos.h

Comment 2 by tbarzic@chromium.org, Apr 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment