New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703833 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocked on:
issue 703852
issue 705255

Blocking:
issue 607968



Sign in to add a comment

roll clang again

Project Member Reported by thakis@chromium.org, Mar 21 2017

Issue description

It's been a while.

We'll pick up lld on linux, and 2-3 weeks of mostly random upstream stuff.

Currently one known blocker.
 

Comment 1 by thakis@chromium.org, Mar 21 2017

Blockedon: 703852

Comment 2 by krasin@chromium.org, Mar 22 2017

Blocking: 607968

Comment 3 by thakis@chromium.org, Mar 22 2017

Blockedon: -703765

Comment 4 by thakis@chromium.org, Mar 22 2017

https://codereview.chromium.org/2771563002/ uploaded fine (I had to fix one ubsan test under windows). I'm waiting for help from goma team for uploading the binaries to goma.

Comment 5 by thakis@chromium.org, Mar 26 2017

Blockedon: 705255
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b3794c961885d1c714213f751846e4539f04042

commit 3b3794c961885d1c714213f751846e4539f04042
Author: thakis <thakis@chromium.org>
Date: Mon Mar 27 17:00:01 2017

Roll clang 296321:298539.

Ran `tools/clang/scripts/upload_revision.py 298539`.

The roll makes the tsan runtime abort on RTLD_DEEPBIND,
so disable one test under tsan that used that.

BUG= 703833 , 705255 
TBR=hans

Review-Url: https://codereview.chromium.org/2771563002
Cr-Commit-Position: refs/heads/master@{#459802}

[modify] https://crrev.com/3b3794c961885d1c714213f751846e4539f04042/base/native_library_unittest.cc
[modify] https://crrev.com/3b3794c961885d1c714213f751846e4539f04042/tools/clang/scripts/update.py

Comment 7 by krasin@chromium.org, Mar 27 2017

Yay! Thanks Nico!

Let's hope it sticks, and I will be able to make the first step in getting rid of the Gold plugin: https://codereview.chromium.org/2766333002/#
Cc: mstarzinger@chromium.org
Anything in this roll that makes former non-throwing "new" throw? We are hitting a few OOMs in V8 that don't properly crash but now bail out in c++. E.g. we now need to fix https://chromium.googlesource.com/v8/v8/+/19f626f076cc/src/allocation.h#46 and explicitly add new(std::nothrow)

Comment 9 by thakis@chromium.org, Mar 28 2017

On Linux?
Yes, but it doesn't seem so. At least I get a repro of  http://crbug.com/705962  also before this clang roll. Just tried locally. So, maybe, never mind :(
Status: Fixed (was: Untriaged)
Declaring this a fixed. Objections?

Sign in to add a comment