New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703827 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Sysmon git metric is of the wrong type (StringMetric)

Project Member Reported by pho...@chromium.org, Mar 21 2017

Issue description

Seeing "ERROR:root:[stderr] __main__.UnstableServices: ['sysmon']" in the logs when doing a test_push.
 

Comment 1 by pho...@chromium.org, Mar 21 2017

Labels: -Pri-3 OS-Chrome Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e46a42b5967a96fe974100237199f525594ceeaf

commit e46a42b5967a96fe974100237199f525594ceeaf
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Mar 22 03:40:20 2017

sysmon: Change git/commit_time to a gauge

The git/commit_time metric should not be a String, because we feed it ints.

TEST=Added a unit test. Changing from String -> Gauge makes the test pass.
BUG= chromium:703827 

Change-Id: I8300ecee2b37676020495a3c100593d2188a1d68
Reviewed-on: https://chromium-review.googlesource.com/457621
Trybot-Ready: Paul Hobbs <phobbs@google.com>
Reviewed-by: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>

[add] https://crrev.com/e46a42b5967a96fe974100237199f525594ceeaf/scripts/sysmon/git_metrics_unittest.py
[modify] https://crrev.com/e46a42b5967a96fe974100237199f525594ceeaf/scripts/sysmon/git_metrics.py

Comment 3 by pho...@chromium.org, Mar 24 2017

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment