New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703818 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 642581



Sign in to add a comment

Remove content target id and target id from transform nodes

Project Member Reported by jaydasika@chromium.org, Mar 21 2017

Issue description

- Necessary to remove target related knowledge out of transform nodes.

- These fields were used in visible rects calculation
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7a8e76c2a53d147b214c67167661e7760d9d5f3

commit f7a8e76c2a53d147b214c67167661e7760d9d5f3
Author: jaydasika <jaydasika@chromium.org>
Date: Wed Mar 22 22:15:21 2017

cc : Delete target id and content target id from transform nodes

They were used in computation of visible rects, but now they are not.

BUG= 703818 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2762043005
Cr-Commit-Position: refs/heads/master@{#458894}

[modify] https://crrev.com/f7a8e76c2a53d147b214c67167661e7760d9d5f3/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/f7a8e76c2a53d147b214c67167661e7760d9d5f3/cc/trees/draw_property_utils.h
[modify] https://crrev.com/f7a8e76c2a53d147b214c67167661e7760d9d5f3/cc/trees/property_tree.cc
[modify] https://crrev.com/f7a8e76c2a53d147b214c67167661e7760d9d5f3/cc/trees/property_tree.h
[modify] https://crrev.com/f7a8e76c2a53d147b214c67167661e7760d9d5f3/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/f7a8e76c2a53d147b214c67167661e7760d9d5f3/cc/trees/property_tree_unittest.cc
[modify] https://crrev.com/f7a8e76c2a53d147b214c67167661e7760d9d5f3/cc/trees/transform_node.cc
[modify] https://crrev.com/f7a8e76c2a53d147b214c67167661e7760d9d5f3/cc/trees/transform_node.h
[modify] https://crrev.com/f7a8e76c2a53d147b214c67167661e7760d9d5f3/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment