New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703813 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

mojo/union.html is timing out

Project Member Reported by dgozman@chromium.org, Mar 21 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58a3da9e52b42cc3f8df506fd40ef4d52e6d2c97

commit 58a3da9e52b42cc3f8df506fd40ef4d52e6d2c97
Author: dgozman <dgozman@chromium.org>
Date: Tue Mar 21 22:18:30 2017

Mark mojo/union.html layout test as timing out.

BUG= 703813 
TBR=damargulis
NOTRY=true

Review-Url: https://codereview.chromium.org/2762983003
Cr-Commit-Position: refs/heads/master@{#458579}

[modify] https://crrev.com/58a3da9e52b42cc3f8df506fd40ef4d52e6d2c97/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d0cdafbcdff0d46261536f4c1881b673ce71ec8

commit 1d0cdafbcdff0d46261536f4c1881b673ce71ec8
Author: damargulis <damargulis@chromium.org>
Date: Wed Mar 22 14:36:38 2017

Fix union test dependencies.

This moves the test_unions.mojom out of test_interfaces_experimental
and deletes test_interfaces_experimental.  test_unions.mojom is
moved into test_interfaces so it is loaded with the rest of the
mojo dependencies.

This is part of moving the mojo tests into LayoutTest, as started
in CL:2744763002, and fixes a bug introduced in that CL causing
union_test.html to timeout since it was unable to find
test_unions.mojom.

This also removes any other calls to test_interfaces_experimental.

BUG= 703813 

Review-Url: https://codereview.chromium.org/2768463004
Cr-Commit-Position: refs/heads/master@{#458746}

[modify] https://crrev.com/1d0cdafbcdff0d46261536f4c1881b673ce71ec8/mojo/edk/js/tests/BUILD.gn
[modify] https://crrev.com/1d0cdafbcdff0d46261536f4c1881b673ce71ec8/mojo/public/cpp/bindings/tests/BUILD.gn
[modify] https://crrev.com/1d0cdafbcdff0d46261536f4c1881b673ce71ec8/mojo/public/interfaces/bindings/tests/BUILD.gn

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f1959982bb4d42a29c0d0cb4678eeda15217ee8

commit 2f1959982bb4d42a29c0d0cb4678eeda15217ee8
Author: damargulis <damargulis@chromium.org>
Date: Mon Mar 27 20:55:49 2017

Revert of Mark mojo/union.html layout test as timing out. (patchset #1 id:1 of https://codereview.chromium.org/2762983003/ )

Reason for revert:
I fixed the bug.
https://codereview.chromium.org/2768463004/

Original issue's description:
> Mark mojo/union.html layout test as timing out.
>
> BUG= 703813 
> TBR=damargulis
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2762983003
> Cr-Commit-Position: refs/heads/master@{#458579}
> Committed: https://chromium.googlesource.com/chromium/src/+/58a3da9e52b42cc3f8df506fd40ef4d52e6d2c97

TBR=dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 703813 

Review-Url: https://codereview.chromium.org/2770913002
Cr-Commit-Position: refs/heads/master@{#459874}

[modify] https://crrev.com/2f1959982bb4d42a29c0d0cb4678eeda15217ee8/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment