A couple more things worth noting that Prudhvi pointed out to me:

- We have an existing pref (sync_promo.show_on_first_run_allowed) which is supposed to suppress our chrome://chrome-signin promo from being displayed. It looks like we're currently not honoring that pref for our new sign-in promo welcome page (chrome://welcome).
- Win10 users may want a way to just suppress the sign-in promo, without necessarily suppressing the Win10 set as default/pin to taskbar welcome page, since that may make more sense in the enterprise environment.

Should we just update sync_promo.show_on_first_run_allowed to also suppress chrome://welcome if it's set as false?

From an eng perspective, I have a bias towards:

- Prefs that can be implemented with a change in only one place

- Broader prefs, rather than exposing controls for individual behaviors and edge-cases

- Either removing or re-appropriating outdated prefs

Note that per  Issue 702576 , we now automatically suppress our new signin promo (chrome://welcome) if sign-in is disabled by policy.

Of course, it may still be valid to want to suppress the first run promo/welcome experience without completely suppressing sign-in by policy, so this is technically still a valid request.

 Issue 782684  has been merged into this issue.

Let's discuss how to handle this. Rather than add new knobs, how about making a blanket suppression of current and future onboarding tabs if distribution first-run tabs are used on first run? This would work for anyone using distribution.first_run_tabs in master_preferences. Do we also need a policy control?

As FYI,  bug 756545  (recently fixed) suppresses the promos if RestoreOnStartup is set.

+Julian who implemented that change

 Issue 787118  has been merged into this issue.

 Issue 263803  has been merged into this issue.

Is there a reason for this issue to be RVG? Can we remove it?

FYI: I've just discovered through some code archaeology that sync_promo.show_on_first_run_allowed regressed in the switch to the new consolidated start-up flow. I think it stopped working in Chrome 57.

It's probably safe to remove RVG.

re: sync_promo.show_on_first_run_allowed, it's been quite awhile now, but I believe that was an intentional (product) decision. Perhaps we meant to deprecate that switch entirely, or reintroduce it depending on postlaunch usage patterns. I remember there being a general principle that we would mostly couple the welcome page to whether Sync was enabled or not--we didn't see it as a priority to allow the configuration where Sync was on but the promo was off.

 Issue 824059  has been merged into this issue.

Removing RVG and assigning to me.

 Issue 601660  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2

commit 146eef8c14ff3a313aa7757ba8dd4bfd17563ad2
Author: Greg Thompson <grt@chromium.org>
Date: Tue Jun 26 09:30:54 2018

Add PromotionalTabsEnabled policy setting.

This setting can be used to control presentation of all full-tab
promotional content. In this iteration, it controls both variants of the
welcome page.

BUG= 703809 

Change-Id: Ib2d87d85807fb86e25833e29b1f2a1ef89b80ca6
Reviewed-on: https://chromium-review.googlesource.com/1105818
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570358}
[modify] https://crrev.com/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2/chrome/browser/ui/startup/startup_browser_creator_impl.h
[modify] https://crrev.com/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2/chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc
[modify] https://crrev.com/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2/chrome/common/pref_names.cc
[modify] https://crrev.com/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2/chrome/common/pref_names.h
[modify] https://crrev.com/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2/components/policy/resources/policy_templates.json
[modify] https://crrev.com/146eef8c14ff3a313aa7757ba8dd4bfd17563ad2/tools/metrics/histograms/enums.xml

 Issue 868243  has been merged into this issue.