New issue
Advanced search Search tips

Issue 703799 link

Starred by 1 user
Status: Fixed
Owner:
thakis@chromium.org
Closed: Mar 2017
Cc:
dpranke@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Remove checked-in .isolate files

Project Member Reported by thakis@chromium.org, Mar 21 2017 
In gyp days, we used handwritten .isolate files to control what gets uploaded to swarming (they were compiled to ".isolated" files). Nowadays, mb/gn generates .isolated files directly, so in theory we shouldn't need all these .isolate files anymore.

I'll try to delete them. Shout if you think we still need them.

Comment 1 by thakis@chromium.org, Mar 21 2017

Status: started (was: Assigned)
https://codereview.chromium.org/2766673003/

Comment 2 by dpranke@chromium.org, Mar 21 2017 

I thought we deleted all of them long ago?

Comment 3 by dpranke@chromium.org, Mar 21 2017 

if we still have them, yes, we should delete them :).
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f526c497b9eae3805d18f71c1cefdf88cfaf8ab5

commit f526c497b9eae3805d18f71c1cefdf88cfaf8ab5
Author: thakis <thakis@chromium.org>
Date: Tue Mar 21 23:05:44 2017

Remove checked-in .isolate files.

If anyone still needs them, please tell me about your use case
(and feel free to revert).

Ran `git ls-files -- '*.isolate' | xargs git rm`

BUG= 703799 
NOTRY=true
TBR=jochen,davidben

Review-Url: https://codereview.chromium.org/2766673003
Cr-Commit-Position: refs/heads/master@{#458595}

[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/base/base.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/build/android/android.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/build/config/win/msvs_dependencies.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/chrome/breakpad.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/chrome/cdb.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/chrome/chrome.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/chrome/ct_skps.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/gin/v8.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/net/net.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/net/tools/testserver/testserver.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/third_party/instrumented_libraries/instrumented_libraries.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/tools/perf/chrome_telemetry_build/telemetry_binary_manager.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/tools/perf/perf.isolate
[delete] https://crrev.com/a5e47761320d73c02ae0473936e059769c42df15/ui/gl/gl.isolate

Comment 6 by thakis@chromium.org, Mar 22 2017

Status: Fixed (was: Started)
Looks like nothing exploded.
►

Sign in to add a comment