New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703792 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Disable stylus tools on pyro

Project Member Reported by jdufault@chromium.org, Mar 21 2017

Issue description

Stylus tools need to be disabled for FSI on pyro, which is using m57.

Minimal patch to disable stylus tools is at https://codereview.chromium.org/2764703002/.
 
Also see b/36367810
Labels: Merge-Request-58
Labels: -Merge-Request-57 Merge-Approved-57
approving merge to M57 Chrome OS.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 28 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56e4af14ffb54959d6302044fca1061292eb8975

commit 56e4af14ffb54959d6302044fca1061292eb8975
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Mar 28 20:25:39 2017

cros: Force disable stylus features on pyro.

Pyro currently reports it has stylus but does not.

BUG= 703792 

Review-Url: https://codereview.chromium.org/2764703002
Cr-Commit-Position: refs/heads/master@{#458501}
(cherry picked from commit 4c42be1964945a0e9254e50020f18f3c1cd346c2)

Review-Url: https://codereview.chromium.org/2786433002 .
Cr-Commit-Position: refs/branch-heads/2987@{#888}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/56e4af14ffb54959d6302044fca1061292eb8975/ash/common/system/chromeos/palette/palette_tray.cc
[modify] https://crrev.com/56e4af14ffb54959d6302044fca1061292eb8975/ash/common/system/chromeos/palette/palette_utils.cc

Project Member

Comment 5 by sheriffbot@chromium.org, Mar 29 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 3 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Merged to m58 as 1cf256a94ec3225b1e238f5d63d375600fd251fa in https://codereview.chromium.org/2795783003
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 7 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-58

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment