New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703769 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 705693



Sign in to add a comment

virtualenv update fails when virtualenv Python is being used simultaneously

Project Member Reported by ayatane@chromium.org, Mar 21 2017

Issue description

The new virtualenv version update feature cannot update the virtualenv Python binary while it is running in another process.

https://luci-logdog.appspot.com/v/?s=chromeos%2Fbb%2Fchromeos%2Fwinky-paladin%2F1076%2F%2B%2Frecipes%2Fsteps%2FUnitTest%2F0%2Fstdout
 
Cc: chingcodes@chromium.org
+chingcodes: This actually caused your failure earlier.
Is there a fix for this? Or just chalk this up to flake until virtualenv can update the binary?
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/790213239577934bc9ef64172abbde6290a4b8c7

commit 790213239577934bc9ef64172abbde6290a4b8c7
Author: Allen Li <ayatane@google.com>
Date: Tue Mar 21 20:09:02 2017

Remove py_version check

There are some problems with it, so remove for now.

BUG= chromium:703769 
TEST=None

Change-Id: I13b3f7d1c3c10e3a5cf08792adeae377af25cbd9

[modify] https://crrev.com/790213239577934bc9ef64172abbde6290a4b8c7/cros_venv/venvlib.py

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/790213239577934bc9ef64172abbde6290a4b8c7

commit 790213239577934bc9ef64172abbde6290a4b8c7
Author: Allen Li <ayatane@google.com>
Date: Tue Mar 21 20:09:02 2017

Remove py_version check

There are some problems with it, so remove for now.

BUG= chromium:703769 
TEST=None

Change-Id: I13b3f7d1c3c10e3a5cf08792adeae377af25cbd9

[modify] https://crrev.com/790213239577934bc9ef64172abbde6290a4b8c7/cros_venv/venvlib.py

Blocking: 705693
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/99502ddf17d6afba5620737a9b6a83ba897ce5c9

commit 99502ddf17d6afba5620737a9b6a83ba897ce5c9
Author: Allen Li <ayatane@google.com>
Date: Tue Mar 21 20:09:02 2017

Explicitly use Bash for scripts

BUG= chromium:703769 
TEST=None

Change-Id: I582f61ca6eef1e22f04cbb45bc76d0d6be522925

[modify] https://crrev.com/99502ddf17d6afba5620737a9b6a83ba897ce5c9/bin/run_tests

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/8a0697c4fd5f2f62f6e5a917c4227d54f505c5f6

commit 8a0697c4fd5f2f62f6e5a917c4227d54f505c5f6
Author: Allen Li <ayatane@google.com>
Date: Tue Mar 21 20:09:02 2017

Use Certified Correct cd code

BUG= chromium:703769 
TEST=None

Change-Id: I22f646629fb4cee6e847f87101b4bb63dfa33198

[modify] https://crrev.com/8a0697c4fd5f2f62f6e5a917c4227d54f505c5f6/bin/run_tests

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/a30ac59d540419f78826664c21c2f386129918f5

commit a30ac59d540419f78826664c21c2f386129918f5
Author: Allen Li <ayatane@google.com>
Date: Fri Mar 24 23:00:05 2017

Reorganize tests

BUG= chromium:703769 
TEST=None

Change-Id: Id99f43f4aae7218d302905b53389680614ffd2ef

[modify] https://crrev.com/a30ac59d540419f78826664c21c2f386129918f5/cros_venv/test_venvlib.py

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 28 2017

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/b49f0bc2b18ff02cb9e23dfead1507792d2272ec

commit b49f0bc2b18ff02cb9e23dfead1507792d2272ec
Author: Allen Li <ayatane@google.com>
Date: Fri Mar 24 23:00:05 2017

Add verbose flag to run_tests

BUG= chromium:703769 
TEST=None

Change-Id: Ibbc0e6641aa6c84fceed34c29c6128c17e6f4e4e

[modify] https://crrev.com/b49f0bc2b18ff02cb9e23dfead1507792d2272ec/bin/run_tests

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/a980b771f4761eea07e91b4ce625d4a57c94a4a6

commit a980b771f4761eea07e91b4ce625d4a57c94a4a6
Author: Allen Li <ayatane@google.com>
Date: Fri Mar 24 23:00:05 2017

Silence rm errors when no cache files exist

BUG= chromium:703769 
TEST=None

Change-Id: I007038454bf5e5c184345393436b81c8f0718ccc

[modify] https://crrev.com/a980b771f4761eea07e91b4ce625d4a57c94a4a6/bin/run_tests

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/68f42e267043a9d706b94b576c8df75e23488dfe

commit 68f42e267043a9d706b94b576c8df75e23488dfe
Author: Allen Li <ayatane@chromium.org>
Date: Tue Mar 28 03:59:31 2017

Use versioned virtualenv for virtualenv_wrapper

BUG= chromium:703769 
TEST=Run virtualenv’ed unittests

Change-Id: I84834ebca61b0caf7ae99c0cd8aa070ca2b32365
Reviewed-on: https://chromium-review.googlesource.com/461380
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Trybot-Ready: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/68f42e267043a9d706b94b576c8df75e23488dfe/scripts/virtualenv_wrapper.py
[modify] https://crrev.com/68f42e267043a9d706b94b576c8df75e23488dfe/__init__.py
[modify] https://crrev.com/68f42e267043a9d706b94b576c8df75e23488dfe/scripts/virtualenv_wrapper_unittest.py

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/cd19725e9c2008c78c821e4389c54ed6e4768699

commit cd19725e9c2008c78c821e4389c54ed6e4768699
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 29 19:39:38 2017

Project Member

Comment 19 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/cd19725e9c2008c78c821e4389c54ed6e4768699

commit cd19725e9c2008c78c821e4389c54ed6e4768699
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 29 19:39:38 2017

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/c88fa799e3ff0a6c47efed827b2d23b0f46a74b3

commit c88fa799e3ff0a6c47efed827b2d23b0f46a74b3
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 29 19:39:57 2017

Project Member

Comment 21 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/c88fa799e3ff0a6c47efed827b2d23b0f46a74b3

commit c88fa799e3ff0a6c47efed827b2d23b0f46a74b3
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 29 19:39:57 2017

Project Member

Comment 22 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/8a841ebc9f3fae4fec3149628dbc2f492284f6d3

commit 8a841ebc9f3fae4fec3149628dbc2f492284f6d3
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 29 19:40:06 2017

Project Member

Comment 23 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/b844b74f81ac51b5ecd63570d31fade72e1f653e

commit b844b74f81ac51b5ecd63570d31fade72e1f653e
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 29 19:40:33 2017

Project Member

Comment 24 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/436a1b1f2a9b0062281006d0d30c724314d1e096

commit 436a1b1f2a9b0062281006d0d30c724314d1e096
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 29 19:40:53 2017

Project Member

Comment 25 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/408f74844bf2948cef2e3cfd30c83a5cc85a0959

commit 408f74844bf2948cef2e3cfd30c83a5cc85a0959
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 29 19:41:11 2017

Project Member

Comment 26 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/a7a7878fd212a53fded7e6fca84566f5babd031e

commit a7a7878fd212a53fded7e6fca84566f5babd031e
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 29 19:42:23 2017

Project Member

Comment 27 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/3cc494bea8bd97655540e3f073fc4d3c3c0fe2f0

commit 3cc494bea8bd97655540e3f073fc4d3c3c0fe2f0
Author: Allen Li <ayatane@chromium.org>
Date: Mon Apr 03 20:49:58 2017

Project Member

Comment 28 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/3cc494bea8bd97655540e3f073fc4d3c3c0fe2f0

commit 3cc494bea8bd97655540e3f073fc4d3c3c0fe2f0
Author: Allen Li <ayatane@chromium.org>
Date: Mon Apr 03 20:49:58 2017

Project Member

Comment 29 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/3cc494bea8bd97655540e3f073fc4d3c3c0fe2f0

commit 3cc494bea8bd97655540e3f073fc4d3c3c0fe2f0
Author: Allen Li <ayatane@chromium.org>
Date: Mon Apr 03 20:49:58 2017

Status: Fixed (was: Untriaged)
Project Member

Comment 31 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/eb04d3c07975d0ffe7259b110c6d6235c7c137f4

commit eb04d3c07975d0ffe7259b110c6d6235c7c137f4
Author: Allen Li <ayatane@google.com>
Date: Wed Apr 12 23:07:54 2017

Clear out existing virtualenv when creating

We check whether a virtualenv has been created successfully by the
spec file that is written after the virtualenv has been initialized
and the spec requirements installed.  In the event that a previous run
failed before the spec file was written, we want to clear out the
partially created virtualenv and recreate it fresh.

BUG= chromium:703769 
TEST=virtualenv VM tests

Change-Id: I060f1fa54cea1ac6042a29215d67617ae563a487
Reviewed-on: https://chromium-review.googlesource.com/461229
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/eb04d3c07975d0ffe7259b110c6d6235c7c137f4/cros_venv/venvlib.py

Project Member

Comment 32 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/eb04d3c07975d0ffe7259b110c6d6235c7c137f4

commit eb04d3c07975d0ffe7259b110c6d6235c7c137f4
Author: Allen Li <ayatane@google.com>
Date: Wed Apr 12 23:07:54 2017

Clear out existing virtualenv when creating

We check whether a virtualenv has been created successfully by the
spec file that is written after the virtualenv has been initialized
and the spec requirements installed.  In the event that a previous run
failed before the spec file was written, we want to clear out the
partially created virtualenv and recreate it fresh.

BUG= chromium:703769 
TEST=virtualenv VM tests

Change-Id: I060f1fa54cea1ac6042a29215d67617ae563a487
Reviewed-on: https://chromium-review.googlesource.com/461229
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/eb04d3c07975d0ffe7259b110c6d6235c7c137f4/cros_venv/venvlib.py

Sign in to add a comment