Product registry needs URL hashing. |
||
Issue descriptionFor round 1 of using product registry we are required to hash the urls. String.hashCode() currently in devtools has far too many collisions. In lue of this we (alph@, caseq@) agreed to bring in SHA-1 and only use the top x amount of bytes from the hash. We will likely start with the top 8 bytes and store them as a HEX string.
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9626beccc3f01f82a06a05e563c40b7494ccd1ac commit 9626beccc3f01f82a06a05e563c40b7494ccd1ac Author: allada <allada@chromium.org> Date: Mon Mar 27 14:26:29 2017 [Devtools] Product registry to support prefix & import of data Updated product registry to support prefix domains and hash domain names. We are using top 8 bytes of an sha1 hash for our domain lookup key. Truth table for domain lookup: *** All prefixes assume base domain of "foo.bar" *** (Top row prefixes, left row domain patterns) | a | * | [empty string] foo.bar | 0 | 1 | 1 ax.foo.bar | 1 | 1 | 0 ax.b.foo.bar | 0 | 1 | 0 b.ax.foo.bar | 1 | 1 | 0 * Also added SHA1 from https://codereview.chromium.org/2766823002/. R=caseq,alph BUG= 703762 Review-Url: https://codereview.chromium.org/2772493002 Cr-Commit-Position: refs/heads/master@{#459776} [modify] https://crrev.com/9626beccc3f01f82a06a05e563c40b7494ccd1ac/third_party/WebKit/Source/devtools/front_end/product_registry/ProductNameForURL.js [modify] https://crrev.com/9626beccc3f01f82a06a05e563c40b7494ccd1ac/third_party/WebKit/Source/devtools/front_end/product_registry/ProductRegistryData.js [add] https://crrev.com/9626beccc3f01f82a06a05e563c40b7494ccd1ac/third_party/WebKit/Source/devtools/scripts/convert-3pas-product-registry.js
,
Apr 17 2017
allada@ Can I add my own url -> groupName map to this Product registry? if yes, how?
,
Apr 17 2017
#3 Not yet. We don't have a process in place for this yet, but we will. This initial list we will likely not allow contribution to it and build a second list that users can contribute into on github or or chromium that will override anything from this one. This will likely be a Q2 or Q4.
,
May 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 27 2017