New issue
Advanced search Search tips

Issue 703758 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 714613
issue 714723



Sign in to add a comment

Add a shipping address editor to the payments flow.

Project Member Reported by mad@chromium.org, Mar 21 2017

Issue description

Users should be able to add new shipping addresses from the payments flow.

Mocks: https://folio.googleplex.com/chrome-ux/mocks/329-future-web-pay/latest/desktop#%2F17.png%3Fc=show
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3602142ccdc1689eb297c43e1f5e8d27f680776

commit e3602142ccdc1689eb297c43e1f5e8d27f680776
Author: mad <mad@chromium.org>
Date: Thu Mar 23 02:29:54 2017

Adding new shipping address editor view to payment flow.

BUG= 703758 

Review-Url: https://codereview.chromium.org/2709093006
Cr-Commit-Position: refs/heads/master@{#458983}

[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/app/generated_resources.grd
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/editor_view_controller.h
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/profile_list_view_controller.h
[add] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[add] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/chrome/browser/ui/views/payments/view_stack.cc
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/components/autofill/core/browser/country_combobox_model.h
[modify] https://crrev.com/e3602142ccdc1689eb297c43e1f5e8d27f680776/components/autofill/core/browser/personal_data_manager.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45271937a3aeee0c06e267d33e75d7ea0bee9605

commit 45271937a3aeee0c06e267d33e75d7ea0bee9605
Author: mad <mad@chromium.org>
Date: Thu Apr 13 16:07:38 2017

[Payments] Added region load failure tolerance and tests to PR editor.

BUG= 703758 
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2803443003
Cr-Commit-Position: refs/heads/master@{#464427}

[add] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/payments/DEPS
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/payments/chrome_payment_request_delegate.cc
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/payments/chrome_payment_request_delegate.h
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[add] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/ui/views/payments/validating_combobox.cc
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/ui/views/payments/validating_textfield_unittest.cc
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/browser/ui/views/payments/validation_delegate.h
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/chrome/test/BUILD.gn
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/components/autofill/core/browser/region_combobox_model.cc
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/components/autofill/core/browser/region_combobox_model.h
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/components/autofill/core/browser/region_combobox_model_unittest.cc
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/components/payments/content/payment_request_state.h
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/components/payments/content/payment_response_helper_unittest.cc
[modify] https://crrev.com/45271937a3aeee0c06e267d33e75d7ea0bee9605/components/payments/core/payment_request_delegate.h

Comment 3 by mad@chromium.org, Apr 24 2017

Blockedon: 714723 714613

Comment 4 by mad@chromium.org, May 25 2017

Owner: se...@chromium.org
You could resolve this one once you resolve blocking  issue 714723 .
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Comment 6 by se...@chromium.org, Jul 26 2017

Status: Fixed (was: Started)

Sign in to add a comment