New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 703752 link

Starred by 1 user
Status: WontFix
Owner:
█ justincarlson@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make PpdProvider guarantee it's own lifetime through callbacks

Project Member Reported by justincarlson@chromium.org, Mar 21 2017 
Because the underlying URLFetcher mechanism does not ref its own delegate, users of PpdProvider need to ensure that the object stays in scope through the callback manually.  We should make PpdProvider ref itself through fetches to make using the API less fraught.

Comment 1 by justincarlson@chromium.org, Jan 17 2018

Status: WontFix (was: Assigned)
Just spent some time digging into this, and I think it's not actually an issue.

URLFetcher guarantees both that:

* the (delegate) OnURLFetchComplete callback is done in the same sequence as the fetcher creation
* If the URLFetcher is deleted, the callback will not fire.

Furthermore, PpdProvider runs ~PpdProvider on the same sequence as the fetcher activity.  Thus, if the PpdProvider is destroyed, it shouldn't be racy against any URLFetcher callbacks.
►

Sign in to add a comment