New issue
Advanced search Search tips

Issue 703748 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 771187

Blocking:
issue 680153



Sign in to add a comment

Upstream Python bindings for libfdt

Project Member Reported by sjg@chromium.org, Mar 21 2017

Issue description

With unified builds we want to access the master configuration from Python. While we can use fdtget as a work-around, the cleanest solution is to use a libfdt Python binding.

This bug tracks upstreaming of this work.

 

Comment 1 by sjg@chromium.org, Mar 21 2017

Blocking: 680153

Comment 2 by sjg@chromium.org, Mar 21 2017

Status: Started (was: Untriaged)
This work actually started in mid-November as I could see I would need it:

https://www.spinics.net/lists/devicetree-compiler/msg00847.html

Comment 3 by sjg@chromium.org, Mar 21 2017

Version 11 series has just been accepted:

https://www.spinics.net/lists/devicetree-compiler/msg01196.html

Comment 4 by sjg@chromium.org, Mar 21 2017

Work still to do:

- Detected different versions of Python on the machine
- Install the library from the Makefile

The library only includes enough features to cope with our current needs. If that changes I may need to add a few more functions to the SWIG interface.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d344a05da0584654e9444ad7219b81d55d4e3c02

commit d344a05da0584654e9444ad7219b81d55d4e3c02
Author: Simon Glass <sjg@chromium.org>
Date: Thu Mar 23 03:05:59 2017

dtc: Create our own dtc ebuild, version 1.4.4

Pull in the latest portage ebuild. This will override the one in portage.
We will run like this until all local patches are present in a tagged
release.

For now at least we will not bother with local source since code review
happens upstream.

BUG= chromium:703748 
TEST=sudo emerge dtc; See that it picks up the new version

Change-Id: I687846bfddc5405cc044134b4df602c6dd38a05a
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/457921
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/d344a05da0584654e9444ad7219b81d55d4e3c02/sys-apps/dtc/dtc-1.4.4.ebuild
[add] https://crrev.com/d344a05da0584654e9444ad7219b81d55d4e3c02/sys-apps/dtc/Manifest

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 23 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/781cceec1f7f49538aa84330b15c907d695bc91a

commit 781cceec1f7f49538aa84330b15c907d695bc91a
Author: Simon Glass <sjg@chromium.org>
Date: Thu Mar 23 20:47:19 2017

dtc: Don't require python.pc

Chrome OS uses python-2.7.pc and does not have python.pc like some other
distributions. Update the Makefile so that pylibfdt still gets built.

BUG= chromium:703748 
TEST=sudo emerge dtc

Change-Id: I5226590b457b7d253ce0c629f9598fde0cd8cdd2
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/457923
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/781cceec1f7f49538aa84330b15c907d695bc91a/sys-apps/dtc/files/0006-pylibfdt-Look-for-Python-2.7.patch

Comment 8 by sjg@chromium.org, Mar 24 2017

Cc: vapier@chromium.org
From vapier:

Upstream Makefile should have:

 PKG_CONFIG ?= pkg-config
 ...
   if $(PKG_CONFIG) ...

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9a89618023e1f06e4f286536ffcb0bdab67147a9

commit 9a89618023e1f06e4f286536ffcb0bdab67147a9
Author: Simon Glass <sjg@chromium.org>
Date: Thu Mar 30 00:17:12 2017

dtc: Simplify patch installation

We don't need the for loop since epatch handles this automatically.

BUG= chromium:703748 
TEST=sudo emerge dtc
See that it still applies the patches

Change-Id: Ifb6a19626d9b799e1343827af2c030c1b8037bac
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/461278
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/9a89618023e1f06e4f286536ffcb0bdab67147a9/sys-apps/dtc/dtc-1.4.4-r1.ebuild

Cc: llozano@chromium.org manojgupta@chromium.org
The ebuild should add a dependency on dev-lang/python. Otherwise the build fails because portage starts building it before python.

WARNING: The following packages failed once or more,
but succeeded upon retry. This might indicate incorrect
dependencies.
  sys-apps/dtc-1.4.4-r1

dtc-1.4.4-r1: python pylibfdt/setup.py "-I libfdt -I ." libfdt/fdt.c libfdt/fdt_ro.c libfdt/fdt_wip.c libfdt/fdt_sw.c libfdt/fdt_rw.c libfdt/fdt_strerror.c libfdt/fdt_empty_tree.c libfdt/fdt_addresses.c libfdt/fdt_overlay.c pylibfdt/libfdt_wrap.c
dtc-1.4.4-r1: pylibfdt/libfdt_wrap.c:130:11: fatal error: 'Python.h' file not found
dtc-1.4.4-r1: # include <Python.h>
dtc-1.4.4-r1:           ^~~~~~~~~~
dtc-1.4.4-r1: 1 error generated.

(https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/release/builds/9992/steps/BuildPackages%20%5Bafdo_use%5D/logs/stdio)

Comment 11 by sjg@chromium.org, Mar 31 2017

Hi,

This is covered by this CL:

https://chromium-review.googlesource.com/login/?pli=1#

If you have time, please review it as I would like to get it resolved ASAP.

- Simon
sjg@, The link in #11 does not point to something I can review.
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792

commit dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792
Author: Simon Glass <sjg@chromium.org>
Date: Sat Apr 01 11:24:50 2017

dtc: Add the latest libfdt patches

Add patches needed to use setup.py correctly from ebuilds. These have been
sent upstream. Patches 8 to 13 are still under review.

BUG= chromium:703748 
TEST=sudo emerge dtc
See that it still applies the patches

Change-Id: I783c22af944cb09527b23c96cad9ab295eb91eb0
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/461279
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0008-pylibfdt-Use-environment-to-pass-C-flags-and-files.patch
[modify] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0001-Add-an-initial-Python-library-for-libfdt.patch
[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0009-pylibfdt-Use-package_dir-to-set-the-package-director.patch
[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0013-pylibfdt-Use-the-correct-libfdt-version-in-the-modul.patch
[delete] https://crrev.com/181e0f202c94e538f7ddbb92b430312acf04ebc0/sys-apps/dtc/files/0006-pylibfdt-Look-for-Python-2.7.patch
[modify] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0004-Adjust-libfdt.h-to-work-with-swig.patch
[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0015-pylibfdt-Rename-libfdt.swig-to-libfdt.i.patch
[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/dtc-1.4.4-r2.ebuild
[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0011-pylibfdt-Allow-building-to-be-disabled.patch
[modify] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0005-Build-pylibfdt-as-part-of-the-normal-build-process.patch
[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0006-Correct-typo-s-pylibgfdt-pylibfdt.patch
[modify] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0003-Mention-pylibfdt-in-the-documentation.patch
[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0014-pylibfdt-Use-the-call-function-to-simplify-the-Makef.patch
[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0007-pylibfdt-Allow-pkg-config-to-be-supplied-in-the-envi.patch
[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0016-pylibfdt-Allow-setup.py-to-operation-stand-alone.patch
[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0010-.travis.yml-Add-builds-with-and-without-Python-libra.patch
[modify] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0002-Add-tests-for-pylibfdt.patch
[add] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/files/0012-pylibfdt-Enable-installation-of-Python-module.patch
[rename] https://crrev.com/dbb4ef4ad7e9a2aa2ad3db9959df9eade88c3792/sys-apps/dtc/dtc-1.4.4.ebuild

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/29dcf9b721dbd267ea699078b7386e1b1ed545d3

commit 29dcf9b721dbd267ea699078b7386e1b1ed545d3
Author: Simon Glass <sjg@chromium.org>
Date: Sun Apr 02 00:10:59 2017

dtc: Install pylibfdt

Add dependencies and install files to enable the Python libfdt bindings.

BUG= chromium:703748 
TEST=sudo emerge dtc
echo 'import libfdt' | python

Change-Id: I694b6b3401689371255726309ba9ea0c69a53836
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/457924
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/29dcf9b721dbd267ea699078b7386e1b1ed545d3/sys-apps/dtc/dtc-1.4.4-r3.ebuild
[modify] https://crrev.com/29dcf9b721dbd267ea699078b7386e1b1ed545d3/sys-apps/dtc/dtc-1.4.4.ebuild

Comment 15 by sjg@chromium.org, Apr 3 2017

Status: Looking pretty good - upstream maintainer has applied some patches and asked for a rebase. Mike has provided some comments. Should have a new version out this week.

Comment 16 by sjg@chromium.org, Apr 3 2017

Components: OS>Firmware

Comment 17 by sjg@chromium.org, Apr 10 2017

Now applied upstream. I'll wait for a release and any other comments and then should be able to drop our local patches.

git://git.kernel.org/pub/scm/utils/dtc/dtc.git

e56f2b0 pylibfdt: Use setup.py to build the swig file
896f1c1 pylibfdt: Use Makefile constructs to implement NO_PYTHON
90db6d9 pylibfdt: Allow setup.py to operate stand-alone
b04a2cf pylibfdt: Fix code style in setup.py
1c5170d pylibfdt: Rename libfdt.swig to libfdt.i
ab15256 pylibfdt: Use the call function to simplify the Makefile
9f2e3a3 pylibfdt: Use the correct libfdt version in the module
e91c652 pylibfdt: Enable installation of Python module
8a892fd pylibfdt: Allow building to be disabled
14c4171 pylibfdt: Use package_dir to set the package directory
89a5062 pylibfdt: Use environment to pass C flags and files
4e0e0d0 pylibfdt: Allow pkg-config to be supplied in the environment
756ffc4 Build pylibfdt as part of the normal build process
8cb3896 Adjust libfdt.h to work with swig
b40aa83 Mention pylibfdt in the documentation
12cfb74 Add tests for pylibfdt
50f2507 Add an initial Python library for libfdt

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/039520c9aedd9119e48183154deb8ca8234e0656

commit 039520c9aedd9119e48183154deb8ca8234e0656
Author: Simon Glass <sjg@chromium.org>
Date: Tue Aug 22 02:53:00 2017

dtc: Add the latest libfdt patches

Add more patches to handle pylibfdt and fdtget changes to be applied
upstream.

BUG= chromium:703748 
TEST=sudo emerge dtc
See that it still applies the patches

Change-Id: I33a5963b7520af2321deb02c70214158057a1247
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/624176
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0027-pylibfdt-Allow-reading-integer-values-from-propertie.patch
[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0026-README-Add-a-note-about-test_tree1.dts.patch
[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0018-pylibfdt-Add-a-test-for-use-of-uint32_t.patch
[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0028-fdtget-Split-out-cell-list-display-into-a-new-functi.patch
[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0019-pylibfdt-Use-local-pylibfdt-module.patch
[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0024-pylibfdt-Add-a-method-to-access-the-device-tree-dire.patch
[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0029-fdtget-Support-following-phandles.patch
[rename] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/dtc-1.4.4-r5.ebuild
[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0023-pylibfdt-Add-support-for-fdt_node_offset_by_phandle.patch
[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0022-pylibfdt-Add-support-for-fdt_parent_offset.patch
[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0021-pylibfdt-Add-support-for-fdt_get_phandle.patch
[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0020-tests-Return-a-failure-code-when-any-tests-fail.patch
[add] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/files/0025-pylibfdt-Add-support-for-fdt_subnode_offset.patch
[modify] https://crrev.com/039520c9aedd9119e48183154deb8ca8234e0656/sys-apps/dtc/dtc-1.4.4.ebuild

Comment 19 by sjg@chromium.org, Oct 6 2017

Blockedon: 771187
v1.4.5 has come out and has our changes in it except for the fdtget symlink following. We plan to stop using that when cros_config_host is ready, so I'll hold off switching back to upstream until then.

Comment 20 by sjg@chromium.org, Nov 4 2017

Labels: Unibuild
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/26439d5dd628fdd47163dce1ab638bff99c7497c

commit 26439d5dd628fdd47163dce1ab638bff99c7497c
Author: Simon Glass <sjg@chromium.org>
Date: Mon Nov 13 03:59:38 2017

commands: Use cros_config_host instead of fdtget

The fdtget tool provides low-level access to the master configuration.
We should use cros_config_host instead since it is the official tool and
has test coverage.

BUG= chromium:703748 
TEST=manually run ./build_stages_unittest and ./command_unittest

Change-Id: Ie663a846fc89be92709c9d8fca03dd80e96fa2f1
Reviewed-on: https://chromium-review.googlesource.com/742665
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>

[modify] https://crrev.com/26439d5dd628fdd47163dce1ab638bff99c7497c/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/26439d5dd628fdd47163dce1ab638bff99c7497c/cbuildbot/commands.py
[modify] https://crrev.com/26439d5dd628fdd47163dce1ab638bff99c7497c/cbuildbot/commands_unittest.py

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a2b6a1b92b68113bec927a3c2b14858cca641b50

commit a2b6a1b92b68113bec927a3c2b14858cca641b50
Author: Simon Glass <sjg@chromium.org>
Date: Sat Sep 29 07:27:27 2018

dtc: Upgrade to 1.4.7

All of our changes are accepted upstream now. Switch to this upstream
version.

Also pull in some pending patches which simplify the setup.py script,
making it more compatible with portage.

CQ-DEPEND=CL:1240662
BUG= chromium:703748 
TEST=sudo emerge dtc
FEATURES=test sudo -E emerge chromeos-config-tools
(needs a small CL for chromeos-config also)

Change-Id: I41901601f4dd2b1a668327023afb765a505d59e1
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1240693
Reviewed-by: C Shapiro <shapiroc@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0026-README-Add-a-note-about-test_tree1.dts.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/dtc-1.4.4-r6.ebuild
[add] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/files/0002-pylibfdt-Correctly-set-build-output-directory.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0006-Correct-typo-s-pylibgfdt-pylibfdt.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0008-pylibfdt-Use-environment-to-pass-C-flags-and-files.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0016-pylibfdt-Allow-setup.py-to-operation-stand-alone.patch
[add] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/files/0005-pylibfdt-Make-SETUP-make-variable.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0012-pylibfdt-Enable-installation-of-Python-module.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0029-fdtget-Support-following-phandles.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0001-Add-an-initial-Python-library-for-libfdt.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0009-pylibfdt-Use-package_dir-to-set-the-package-director.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0025-pylibfdt-Add-support-for-fdt_subnode_offset.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0028-fdtget-Split-out-cell-list-display-into-a-new-functi.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0014-pylibfdt-Use-the-call-function-to-simplify-the-Makef.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0018-pylibfdt-Add-a-test-for-use-of-uint32_t.patch
[rename] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/dtc-1.4.7.ebuild
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0023-pylibfdt-Add-support-for-fdt_node_offset_by_phandle.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0022-pylibfdt-Add-support-for-fdt_parent_offset.patch
[add] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/files/0008-pylibfdt-Eliminate-run_setup-make-function.patch
[add] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/files/0009-pylibfdt-Don-t-have-setup.py-depend-on-where-it-s-in.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0010-.travis.yml-Add-builds-with-and-without-Python-libra.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0002-Add-tests-for-pylibfdt.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0015-pylibfdt-Rename-libfdt.swig-to-libfdt.i.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0013-pylibfdt-Use-the-correct-libfdt-version-in-the-modul.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0019-pylibfdt-Use-local-pylibfdt-module.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0017-pylibfdt-Add-stdint-include-to-fix-uint32_t.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0005-Build-pylibfdt-as-part-of-the-normal-build-process.patch
[add] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/dtc-1.4.7-r1.ebuild
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0021-pylibfdt-Add-support-for-fdt_get_phandle.patch
[add] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/files/0006-pylibfdt-Don-t-silence-setup.py-when-V-1.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0003-Mention-pylibfdt-in-the-documentation.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0011-pylibfdt-Allow-building-to-be-disabled.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0027-pylibfdt-Allow-reading-integer-values-from-propertie.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0004-Adjust-libfdt.h-to-work-with-swig.patch
[add] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/files/0004-pylibfdt-Simpler-CFLAGS-handling.patch
[add] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/files/0003-pylibfdt-Link-extension-module-with-libfdt-rather-th.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0024-pylibfdt-Add-a-method-to-access-the-device-tree-dire.patch
[add] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/files/0001-pylibfdt-We-don-t-need-include-files-from-the-base-d.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0007-pylibfdt-Allow-pkg-config-to-be-supplied-in-the-envi.patch
[delete] https://crrev.com/39cdc7470a1889304cf3bc2446f984b0f527890e/sys-apps/dtc/files/0020-tests-Return-a-failure-code-when-any-tests-fail.patch
[add] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/files/0007-pylibfdt-Improved-version-extraction.patch
[modify] https://crrev.com/a2b6a1b92b68113bec927a3c2b14858cca641b50/sys-apps/dtc/Manifest

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9504dbe4e8351eaef689b9e673e173fd4c411f4b

commit 9504dbe4e8351eaef689b9e673e173fd4c411f4b
Author: Simon Glass <sjg@chromium.org>
Date: Sat Sep 29 07:27:27 2018

chromeos-config: Adjust Fdt implementation for upstream

There was a change requested when upstreaming the pylibfdt
implementation. Update the code to suit.

CQ-DEPEND=CL:1240693
BUG= chromium:703748 
TEST=sudo emerge dtc
FEATURES=test sudo -E emerge chromeos-config-tools

Change-Id: Ia85140c5e5f6c99178d59e477cbacc5980f1493e
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1240662
Reviewed-by: C Shapiro <shapiroc@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9504dbe4e8351eaef689b9e673e173fd4c411f4b/chromeos-config/cros_config_host/fdt.py

Status: Fixed (was: Started)
This work is done now

Sign in to add a comment