AndroidCellularSignalStrength should register as a signal strength change listener |
||||||
Issue descriptionAndroidCellularSignalStrength.java currently calls getAllCellInfo() to obtain the cellular signal strength. There are no guarantees that getAllCellInfo() would return immediately, and in the worst case may take up to 1-5 seconds. Instead of calling getAllCellInfo(), AndroidCellularSignalStrength.java should register as a listener to the changes in the cellular signal strength. This has the additional benefit that the updated signal strength is always available to Chrome.
,
Mar 21 2017
priority++ for blocking IO thread
,
Mar 21 2017
CL under review: https://codereview.chromium.org/2763853002/
,
May 4 2017
,
May 24 2017
,
May 24 2017
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de702d52aea0e1daae4a827d0eb3fe3d4d477b68 commit de702d52aea0e1daae4a827d0eb3fe3d4d477b68 Author: tbansal <tbansal@chromium.org> Date: Wed Jun 28 14:23:36 2017 Use Android callback API to obtain cellular signal strength Move cellular signal strength methods to a class. Also, use the PhoneStateListener to listen to the changes in the signal strength. BUG= 703740 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2763853002 Cr-Commit-Position: refs/heads/master@{#482981} [modify] https://crrev.com/de702d52aea0e1daae4a827d0eb3fe3d4d477b68/net/android/cellular_signal_strength.cc [modify] https://crrev.com/de702d52aea0e1daae4a827d0eb3fe3d4d477b68/net/android/cellular_signal_strength.h [modify] https://crrev.com/de702d52aea0e1daae4a827d0eb3fe3d4d477b68/net/android/cellular_signal_strength_unittest.cc [modify] https://crrev.com/de702d52aea0e1daae4a827d0eb3fe3d4d477b68/net/android/java/src/org/chromium/net/AndroidCellularSignalStrength.java [modify] https://crrev.com/de702d52aea0e1daae4a827d0eb3fe3d4d477b68/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/de702d52aea0e1daae4a827d0eb3fe3d4d477b68/net/nqe/network_quality_estimator.h [modify] https://crrev.com/de702d52aea0e1daae4a827d0eb3fe3d4d477b68/net/nqe/network_quality_estimator_params.cc [modify] https://crrev.com/de702d52aea0e1daae4a827d0eb3fe3d4d477b68/net/nqe/network_quality_estimator_params.h [modify] https://crrev.com/de702d52aea0e1daae4a827d0eb3fe3d4d477b68/net/nqe/network_quality_observation.h [modify] https://crrev.com/de702d52aea0e1daae4a827d0eb3fe3d4d477b68/net/nqe/observation_buffer.h [modify] https://crrev.com/de702d52aea0e1daae4a827d0eb3fe3d4d477b68/tools/metrics/histograms/histograms.xml
,
Jul 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tbansal@chromium.org
, Mar 21 2017