New issue
Advanced search Search tips

Issue 703733 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add UMA to help decide when to remove the docked enum from windows.json

Project Member Reported by afakhry@chromium.org, Mar 21 2017

Issue description

Docked Windows have been deprecated in Issue 668355. We updated the documentation of our extensions API to announce that this feature is deprecated. 

We need to add UMA to report how often this feature is requested in the API and decide when to remove it. [https://cs.chromium.org/chromium/src/chrome/common/extensions/api/windows.json?type=cs&q=f:windows.json+docked&l=23]
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4b59de15639559e9fbdc818d3ca1ca960dbc0c0

commit b4b59de15639559e9fbdc818d3ca1ca960dbc0c0
Author: afakhry <afakhry@chromium.org>
Date: Fri Mar 31 05:02:14 2017

Send UMA about requested window state from tabs API

As part of the deprecation of docked windows, we need to record some
UMA stats to track the number of times the "docked" window state was
requested, so that we can remove it at the appropriate milestone.

BUG= 703733 

Review-Url: https://codereview.chromium.org/2779683004
Cr-Commit-Position: refs/heads/master@{#461044}

[modify] https://crrev.com/b4b59de15639559e9fbdc818d3ca1ca960dbc0c0/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/b4b59de15639559e9fbdc818d3ca1ca960dbc0c0/chrome/common/extensions/api/windows.json
[modify] https://crrev.com/b4b59de15639559e9fbdc818d3ca1ca960dbc0c0/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Thanks!  Can we either repurpose this bug or file a new one for actually removing the enum, if UMA indicates we can?
Done. Filed Issue 707260.

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment