New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703731 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

full black background for maximized portrait only arc++ apps

Project Member Reported by osh...@chromium.org, Mar 21 2017

Issue description

full black background for maximized portrait only arc++ apps

(basically do the same thing as immersive fullscreen)
 

Comment 1 by osh...@chromium.org, Mar 21 2017

this is chrome side bug for b/36393672
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69232cda736bc8b0570bc833ceb2323bf6bcd451

commit 69232cda736bc8b0570bc833ceb2323bf6bcd451
Author: oshima <oshima@chromium.org>
Date: Wed Mar 22 01:30:53 2017

Add black background to ARC maximzied window as well as fullscreen.

BUG= 703731 
TEST=unit tests, manual

Review-Url: https://codereview.chromium.org/2764733002
Cr-Commit-Position: refs/heads/master@{#458609}

[modify] https://crrev.com/69232cda736bc8b0570bc833ceb2323bf6bcd451/components/exo/shell_surface.cc
[modify] https://crrev.com/69232cda736bc8b0570bc833ceb2323bf6bcd451/components/exo/shell_surface_unittest.cc

Comment 3 by osh...@chromium.org, Mar 22 2017

Labels: Merge-Request-58
q
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 23 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e536072570112b5d69fb6f62553336f4885f8cd

commit 2e536072570112b5d69fb6f62553336f4885f8cd
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Mar 23 22:46:44 2017

Add black background to ARC maximzied window as well as fullscreen.

BUG= 703731 
TEST=unit tests, manual

Review-Url: https://codereview.chromium.org/2764733002
Cr-Commit-Position: refs/heads/master@{#458609}
(cherry picked from commit 69232cda736bc8b0570bc833ceb2323bf6bcd451)

Review-Url: https://codereview.chromium.org/2771663005 .
Cr-Commit-Position: refs/branch-heads/3029@{#398}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/2e536072570112b5d69fb6f62553336f4885f8cd/components/exo/shell_surface.cc
[modify] https://crrev.com/2e536072570112b5d69fb6f62553336f4885f8cd/components/exo/shell_surface_unittest.cc

Comment 6 by osh...@chromium.org, Mar 23 2017

Status: Fixed (was: Started)

Comment 7 by cda...@chromium.org, May 24 2017

Components: Platform>Apps>ARC

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment