DCHECK hit when reloading from omnibox |
|||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): Top of tree iOS Version: All Device: All Steps to reproduce: 1. visit http://www.chromium.org 2. tap omnibox 3. tap enter Observed behavior: DCHECK hit in |CRWWebController loadWithParams| [0321/182024.588335:FATAL:crw_web_controller.mm(1807)] Check failed: self.nativeController || !(transition & ui::PAGE_TRANSITION_RELOAD) || self.navigationManagerImpl->GetTransientItem(). Not sure of the consequences in release.
,
Mar 21 2017
,
Mar 21 2017
We want omnibox interactions that look like reloads not to contribute to statistics as a typed navigation. Reloads are not that strong a signal. When a user reloads a page, using the omnibox or not, it does not necessarily provide evidence that the user has seen the URL and would want to navigate to the URL via typing in the omnibox.
,
Mar 21 2017
Thanks! Sounds like that DCHECK should be removed from web controller.
,
Mar 23 2017
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6eb96d661fb4e2ddf0ab5baaf6ee389854f0a86 commit e6eb96d661fb4e2ddf0ab5baaf6ee389854f0a86 Author: eugenebut <eugenebut@chromium.org> Date: Fri Mar 24 16:05:17 2017 Removed invalid DCHECK from |loadWithParams:|. Omnibox legitimately passes PAGE_TRANSITION_RELOAD for the same page loads. BUG= 703709 Review-Url: https://codereview.chromium.org/2772903002 Cr-Commit-Position: refs/heads/master@{#459441} [modify] https://crrev.com/e6eb96d661fb4e2ddf0ab5baaf6ee389854f0a86/ios/web/web_state/ui/crw_web_controller.mm
,
Mar 24 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by eugene...@chromium.org
, Mar 21 2017Components: UI>Browser>Omnibox
Labels: -Pri-2 Pri-3