Correctly handle native error pages in CRWWebController's |-reload| |
||
Issue descriptionCurrently, CRWWebController's |-reload| will simply call CRWNativeContent's |-reload| if there is no web view. However, when a native controller is used to display an error page, this is incorrect behavior, as we'd want to attempt to reload the URL that caused the error. Rather than checking whether the web view exists, we should be checking whether the current URL should be loaded in a native controller.
,
Mar 21 2017
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d163839906a68671aea3291a7606babbfc72999 commit 2d163839906a68671aea3291a7606babbfc72999 Author: kkhorimoto <kkhorimoto@chromium.org> Date: Tue Mar 21 19:09:22 2017 Correctly reload URLs in web views if a native controller is displayed. If a page has failed to load, a native controller is used to display the error page. However, if NavigationManager::Reload() is called while an error page is displayed, we want to attempt to reload the current NavigationItem's URL, not the native error page. BUG= 703707 Review-Url: https://codereview.chromium.org/2765903003 Cr-Commit-Position: refs/heads/master@{#458499} [modify] https://crrev.com/2d163839906a68671aea3291a7606babbfc72999/ios/web/web_state/ui/crw_web_controller.mm
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d163839906a68671aea3291a7606babbfc72999 commit 2d163839906a68671aea3291a7606babbfc72999 Author: kkhorimoto <kkhorimoto@chromium.org> Date: Tue Mar 21 19:09:22 2017 Correctly reload URLs in web views if a native controller is displayed. If a page has failed to load, a native controller is used to display the error page. However, if NavigationManager::Reload() is called while an error page is displayed, we want to attempt to reload the current NavigationItem's URL, not the native error page. BUG= 703707 Review-Url: https://codereview.chromium.org/2765903003 Cr-Commit-Position: refs/heads/master@{#458499} [modify] https://crrev.com/2d163839906a68671aea3291a7606babbfc72999/ios/web/web_state/ui/crw_web_controller.mm
,
Mar 21 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by kkhorimoto@chromium.org
, Mar 21 2017