The settings reset prompt should get focus when shown. |
||||||
Issue descriptionCurrently, the settings reset dialog does not take focus when shown. But it should take focus, since we want it to behave as a modal dialog due to the severity of the problem that it tries to help the user fix.
,
Mar 23 2017
,
Mar 23 2017
This is a small CL that fixes a dialog focus issue taht we would like to merge to M58. The CL has been manually tested on Canary channel (build 3049)
,
Mar 23 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bef26134ea67d318ceb4ed0a5d9c10bcc5f6d9d commit 3bef26134ea67d318ceb4ed0a5d9c10bcc5f6d9d Author: Chris Sharp <csharp@chromium.org> Date: Thu Mar 23 17:26:09 2017 Settings reset prompt: the dialog should have focus when shown. BUG= 703701 Review-Url: https://codereview.chromium.org/2764033004 Cr-Commit-Position: refs/heads/master@{#458603} (cherry picked from commit e33bb720f168fdb711b15b20832632970166a81b) Review-Url: https://codereview.chromium.org/2763413006 . Cr-Commit-Position: refs/branch-heads/3029@{#388} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/3bef26134ea67d318ceb4ed0a5d9c10bcc5f6d9d/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc
,
Mar 29 2017
Tested the issue on windows 7,Ubuntu 14.04 and Mac 10.12.3 using chrome version 58.0.3029.41 with the below steps 1. Open chrome://settings 2.clicked on Reset settings button 3.Observed that the focus is there on Reset dialog Please find the attached screen cast and confirm if anything missed here. Please confirm on the expected behaviour. Thanks,
,
Mar 29 2017
This bug refers to a different reset dialog. For instructions on how to trigger that dialog, please see the detailed test plan for the feature (you only need to try one test case): https://docs.google.com/document/d/1TlXy5iQlUESW5xlkd20paVzSBSEI3BzQyaGSKgfME5Y/edit#heading=h.ywo9tflaxbap Let me know if you need more information.
,
Mar 30 2017
Thanks for the update Tested the issue on windows 7 using chrome version 58.0.3029.41 with the below steps 1.Launch chrome with all the prerequisites and flags mentioned in above document. 2.Reset dialog opened 3.Observed the focus is there on dialog. Please find the attached screen cast for the same.Adding TE-Verified labels. Thanks, |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 21 2017