New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703698 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Bluetooth scanning does not stop when closing chrome://md-settings page

Project Member Reported by varkha@chromium.org, Mar 21 2017

Issue description

Chrome Version: 58.0.3029.18
OS: Chrome OS

What steps will reproduce the problem?
(1) Navigate to chrome://md-settings and turn BT on
(2) Play audio media over BT headphones
(3) Open Bluetooth settings (audio starts to stutter - see a separate bug 700959)
(4) Close chrome://md-settings window

What is the expected result?
Bluetooth scanning stops

What happens instead?
Audio continues to stutter which *suggests* that the Bluetooth scanning is not stopped.
 
Cc: scheib@chromium.org
Owner: steve...@chromium.org
Status: Assigned (was: Unconfirmed)
rkc@, scheib@ - Is there a way to tell whether or not scanning is in progress? Do we log that anywhere?

After step 4 in #0 , we can see that the Bluetooth scanning is still on in the bt_console page in shell. 

But i don't see any audio sluttering.

Comment 3 by varkha@chromium.org, Mar 22 2017

#2, interesting, maybe you can comment on bug 700959, I could see it on 2 different samus devices although I've only tried one set of headphones (I've mentioned the exact setup on that other bug).

Comment 4 by ketakid@google.com, Mar 24 2017

Components: IO>Bluetooth
Components: UI>Settings
Labels: -M-58 ReleaseBlock-Stable M-59
MD settings is only a Finch experiment in M58
Labels: Hotlist-MD-Settings-Bluetooth
This can also be detected by observing chrome://bluetooth-internals/#adapter

Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4de1dce7be5bc5c6fcf4615478757773dace027

commit f4de1dce7be5bc5c6fcf4615478757773dace027
Author: stevenjb <stevenjb@chromium.org>
Date: Thu Apr 13 02:47:46 2017

MD Settings: Bluetooth: Fix adapter state and discovery

This CL:
* Adds some additional bluetooth event logging (USER events).
* Fixes the toggle logic so as not to set powered=false before the
  adapter state is received or when the toggle state matches the
  adapter state.
* Disables the toggle until the adapter state changes (not normally
  observable, but can prevent rapid toggling artifacts).
* Modifies BluetoothEventRouter to stop discovery when all WebUI tabs
  (or all tabs/windows associated with an extension) are closed.

BUG= 703694 , 703698 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2801403002
Cr-Commit-Position: refs/heads/master@{#464258}

[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/test/data/webui/settings/bluetooth_page_tests.js
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/test/data/webui/settings/fake_bluetooth.js
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/test/data/webui/settings/fake_bluetooth_private.js
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/DEPS
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/bluetooth/bluetooth_api.cc
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/bluetooth/bluetooth_event_router.cc
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/bluetooth/bluetooth_event_router.h
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/bluetooth/bluetooth_event_router_unittest.cc
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/bluetooth/bluetooth_private_api.cc

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-59; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-59 label, otherwise remove Merge-TBD label. Thanks.
Status: Verified (was: Fixed)
verified on 59.0.3071.8
Project Member

Comment 14 by sheriffbot@chromium.org, May 31 2017

Labels: -Merge-TBD

Sign in to add a comment