New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703694 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Navigating to chrome://md-settings turns Bluetooth off

Project Member Reported by varkha@chromium.org, Mar 21 2017

Issue description

Chrome Version: 58.0.3029.18
OS: Chrome OS

What steps will reproduce the problem?
(1) Connect BT headphones and play media
(2) Navigate to chrome://md-settings

What is the expected result?
Playback is not interrupted

What happens instead?
Playback stops, the page shows Bluetooth toggle as off.

See also bug 700959.

 
Cc: scheib@chromium.org
Labels: -Pri-2 Pri-1
Owner: steve...@chromium.org
Status: Assigned (was: Unconfirmed)
Hmm, this is surprising and I can't reproduce without a connected device, can someone verify this?

Also, could you clarify 'play media' in case that is a factor (and confirm the repeatability of this? Does it occur if settings is already open or was already open?)

Comment 2 by varkha@chromium.org, Mar 21 2017

#1, on my samus I can reproduce this by those steps (no device involved although I have phone shown there as a paired device and I have smart lock enabled.
+ Tap system tray, verify BT is enabled.
+ Open a new window, type chrome://md-settings in URL
Bluetooth toggle momentarily shows on but immediately gets turned off.
Verifying in system tray - BT is now turned off.
I can not reproduce #2 on a ToT build. I will try on a 58 build some time this week.

Labels: Hotlist-MD-Settings-Bluetooth
Components: UI>Settings
Labels: -M-58 ReleaseBlock-Stable M-59
Verified with comment #2 on samus on 58.0.3029.40. Doesn't require any paired device.

Does not repro on old Options. Repros consistently in MD Settings.
also on 58.0.3029.51.
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4de1dce7be5bc5c6fcf4615478757773dace027

commit f4de1dce7be5bc5c6fcf4615478757773dace027
Author: stevenjb <stevenjb@chromium.org>
Date: Thu Apr 13 02:47:46 2017

MD Settings: Bluetooth: Fix adapter state and discovery

This CL:
* Adds some additional bluetooth event logging (USER events).
* Fixes the toggle logic so as not to set powered=false before the
  adapter state is received or when the toggle state matches the
  adapter state.
* Disables the toggle until the adapter state changes (not normally
  observable, but can prevent rapid toggling artifacts).
* Modifies BluetoothEventRouter to stop discovery when all WebUI tabs
  (or all tabs/windows associated with an extension) are closed.

BUG= 703694 , 703698 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2801403002
Cr-Commit-Position: refs/heads/master@{#464258}

[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/test/data/webui/settings/bluetooth_page_tests.js
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/test/data/webui/settings/fake_bluetooth.js
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/chrome/test/data/webui/settings/fake_bluetooth_private.js
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/DEPS
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/bluetooth/bluetooth_api.cc
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/bluetooth/bluetooth_event_router.cc
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/bluetooth/bluetooth_event_router.h
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/bluetooth/bluetooth_event_router_unittest.cc
[modify] https://crrev.com/f4de1dce7be5bc5c6fcf4615478757773dace027/extensions/browser/api/bluetooth/bluetooth_private_api.cc

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-59; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-59 label, otherwise remove Merge-TBD label. Thanks.
Issue still observed on ChromeOS-test-R60-9469.0.0. Kindly let me know when this is going to get merged 
Crhome is still at 59.0.3070.0 in that version, which corresponds to commit #464226.

The fix landed at #464258.

It should be in the next *Chrome* update, which is behind a bit due to a series of cascading failures in the PFQ.

Status: Verified (was: Fixed)
This is now fixes in 59.0.3071.15 / 9460.5.0 build
Project Member

Comment 15 by sheriffbot@chromium.org, Jun 5 2017

Labels: -Merge-TBD

Sign in to add a comment