Latest Chrome stable (57.0.2987.110) breaks one of my site's layouts
Reported by
jgolterm...@gmail.com,
Mar 21 2017
|
|||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.110 Safari/537.36 Example URL: https://createtv.com/recipes/cooking Steps to reproduce the problem: 1. Test https://createtv.com/recipes/cooking under Chrome < 57.0.2987.110, or under MS Edge, Firefox or Safari 2. Observe that the page looks OK 3. Test https://createtv.com/recipes/cooking under Chrome == 57.0.2987.110 4. Observe how the layout is significantly messed up. What is the expected behavior? The captions for each entry on that page should be aligned with the bottom of each entry's image. The overlay image should appear over the lower-right of each entry's image. What went wrong? The captions often don't show, nor does the overlay image. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? Yes 57.0.2987.98 Does this work in other browsers? Yes Chrome version: 57.0.2987.110 Channel: stable OS Version: 10.0 Flash Version: This is not specific to the Windows version -- I can replicate this error under MacOS Sierra, under Linux (Manjaro), Windows 10 and Windows 7. It's specific to the rendering engine.
,
Mar 21 2017
,
Mar 21 2017
,
Mar 21 2017
askatte@, can you check this on Android?
,
Mar 21 2017
Repros on M57 - 57.0.2987.118 / Pixel XL/ 7.1.1 (on other devices too).
,
Mar 21 2017
Applying OS=Android per comment #5.
,
Mar 21 2017
Reproducible on CrOS 9202.54.0/57.0.2987.115 - Candy Device as well.
,
Mar 21 2017
,
Mar 21 2017
,
Mar 21 2017
Thanks for the report, and sorry for the break. jgoltermann@gmail.com before we launch the fix, can you try a workaround first by adding a rule: a { opacity: 1; } below the following rule in style.css: h1, h2, h3, h4, h5, h6, p, table, ul, li, a { opacity: .999; font-weight: normal; margin: 0; padding: 0; }
,
Mar 21 2017
Reduced test case
,
Mar 21 2017
Done; it looks much better, but those captions are not meant to be intersecting the image. They should be floating just below the images, but the left-hand edge of the captions are at roughly the intended location. Thanks very much for the rapid response and turnaround! I look forward to the full bug-fix!
,
Mar 21 2017
Thanks for trying it. I tried the new version and Firefox also showed the same result, even with "opacity: 1" removed. Are there any other changes?
,
Mar 21 2017
Gah! Confirmed, and on Microsoft Edge, and Safari 10.0.3. (D'oh!) OK, I'll take it. I can at least get the CSS corrected myself. Thanks very much for this! You guys rock! BTW, when can I expect the fix to go out? Next minor release? Thanks in advance for any insight you can offer.
,
Mar 21 2017
Proposed fix: https://codereview.chromium.org/2761413002/
,
Mar 21 2017
The fix doesn't fix bug 703481, and I'm afraid there are other corner cases that are broken by r445591, so now I'm inclined to revert r445591 and r442046. This will reopen bug 666553 which had existed before m57. Add Merge-Request-57 for the reverts.
,
Mar 21 2017
I need some time to build, test and confirm. Before that, I would like to evaluate the impact of this bug and bug 703481 first. If the impact is low, we will leave m57 as-is, and provide workaround methods for the sites, and fix the bugs in m58 and m59. The evaluation may need several hours to finish.
,
Mar 21 2017
Re #18: Ok,sounds good. Please keep us posted.
,
Mar 22 2017
Approving merge of https://codereview.chromium.org/2761413002/ for M57 branch 2987 and M58 branch 3029.
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be8909e4d0dfe024e1b39f5abf195e63d97652ae commit be8909e4d0dfe024e1b39f5abf195e63d97652ae Author: wangxianzhu <wangxianzhu@chromium.org> Date: Wed Mar 22 20:17:46 2017 Fix position of layer with floating ancestor within inline parent layer <span style="position: relative"> ... <div style="float: left"> ... <target layer> ... </div> ... </span> Because of the floating ancestor, the containing layer of target layer is not the span, but the layer found in the containing block chain. BUG= 703666 ,703481 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2761413002 Cr-Commit-Position: refs/heads/master@{#458857} [modify] https://crrev.com/be8909e4d0dfe024e1b39f5abf195e63d97652ae/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp [modify] https://crrev.com/be8909e4d0dfe024e1b39f5abf195e63d97652ae/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/be8909e4d0dfe024e1b39f5abf195e63d97652ae/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
,
Mar 22 2017
Issue 703481 has been merged into this issue.
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05de6acd8ec79f95dede0ed751a5be65e8b35c47 commit 05de6acd8ec79f95dede0ed751a5be65e8b35c47 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Wed Mar 22 23:48:59 2017 Fix position of layer with floating ancestor within inline parent layer <span style="position: relative"> ... <div style="float: left"> ... <target layer> ... </div> ... </span> Because of the floating ancestor, the containing layer of target layer is not the span, but the layer found in the containing block chain. BUG= 703666 ,703481 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 NOPRESUBMIT=true NOTRY=true R=chrishtr Review-Url: https://codereview.chromium.org/2761413002 Cr-Original-Commit-Position: refs/heads/master@{#458857} Review-Url: https://codereview.chromium.org/2767133003 Cr-Commit-Position: refs/branch-heads/2987@{#865} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/05de6acd8ec79f95dede0ed751a5be65e8b35c47/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/05de6acd8ec79f95dede0ed751a5be65e8b35c47/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a63a4e804574974a127ee0920f65628374257ebb commit a63a4e804574974a127ee0920f65628374257ebb Author: wangxianzhu <wangxianzhu@chromium.org> Date: Wed Mar 22 23:56:24 2017 Fix position of layer with floating ancestor within inline parent layer <span style="position: relative"> ... <div style="float: left"> ... <target layer> ... </div> ... </span> Because of the floating ancestor, the containing layer of target layer is not the span, but the layer found in the containing block chain. BUG= 703666 ,703481 NOTRY=true NOPRESUBMIT=true TBR=wangxianzhu@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2761413002 Cr-Original-Commit-Position: refs/heads/master@{#458857} Review-Url: https://codereview.chromium.org/2770713004 Cr-Commit-Position: refs/branch-heads/3029@{#375} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/a63a4e804574974a127ee0920f65628374257ebb/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp [modify] https://crrev.com/a63a4e804574974a127ee0920f65628374257ebb/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/a63a4e804574974a127ee0920f65628374257ebb/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
,
Mar 23 2017
Will mark this as fixed since the patch has landed across all applicable branches. Please file a new bug to track any required follow-up (e.g. a reland of the applicable functionality with the regression addressed).
,
Mar 23 2017
Verified this issue on Ubuntu 14.04, Windows-10 and Mac OS 10.12 using chrome latest stable #57.0.2987.123. By opening the test case file recipe.html from comment #11 observed that the text is placed inside the box as expected. Hence adding TE-Verified label. Thanks!
,
Mar 23 2017
Verified the issue on Chrome 57.0.2987.123/CrOS 9202.56.1 (Peppy) with the testcase recipe.html (comment #11).
,
Mar 23 2017
Thank you for fixing the bug. Requesting postmortem for this please see go/chrome-postmortems for the process to follow).
,
Mar 28 2017
schenney@ will you write postmortem for this bug? I have created a blank version (chromepostmortem374), and just changed the owner to you.
,
Mar 28 2017
Is there a reason this bug was activated again? Can we please close if this is fixed and verified already?
,
Mar 28 2017
,
Mar 29 2017
Tested the issue on windows 7,Ubuntu 14.04 and Mac 10.12.3 using chrome version 58.0.3029.41 with the attached html file from comment #11. Observed the text is inside the box. Please find the attached screen shot for the same. Ading TE-Verified labels. Thanks,
,
Mar 29 2017
Android: Issue is verified in M58- 58.0.3029.42 on Samsung Galaxy TAB 3 10.1 (GT-P5210) KOT49H |
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by pbomm...@chromium.org
, Mar 21 2017Components: Blink>Paint
Labels: -Pri-2 -Type-Compat M-57 ReleaseBlock-Stable Pri-1 Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)