Issue metadata
Sign in to add a comment
|
Text fields not handling ACTION_CLICK properly on Android |
||||||||||||||||||||||
Issue descriptionb/36140491 The talkback webview sample doesn't work with Switch Access either. I think WebView isn't handling the ACTION_CLICK properly for text and password input elements. For O, TalkBack is using the same API to click as other services, so its regression is likely uncovering an underlying issue with WebView.
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbf2ebc6e589a5aa81d29c78cf392182de4329bb commit cbf2ebc6e589a5aa81d29c78cf392182de4329bb Author: dmazzoni <dmazzoni@chromium.org> Date: Fri Mar 24 16:22:13 2017 AXObject::performDefaultAction() should focus if it can't click The user-visible bug here is that sending a CLICK event to a text field on Android does nothing, because a text field doesn't have a default action. I could fix this on the Android side, but this seems wrong to me. If performDefaultAction() is called on a focusable control, I think the natural thing to do is focus it if there's no "press" behavior. So I think we should handle that generally. Let me know if you have any objection and I could make it more narrow. But to me it seems more useful this way. BUG= 703659 Review-Url: https://codereview.chromium.org/2772913003 Cr-Commit-Position: refs/heads/master@{#459448} [add] https://crrev.com/cbf2ebc6e589a5aa81d29c78cf392182de4329bb/third_party/WebKit/LayoutTests/accessibility/press-works-on-text-fields.html [modify] https://crrev.com/cbf2ebc6e589a5aa81d29c78cf392182de4329bb/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp [modify] https://crrev.com/cbf2ebc6e589a5aa81d29c78cf392182de4329bb/third_party/WebKit/Source/modules/accessibility/AXMenuList.h [modify] https://crrev.com/cbf2ebc6e589a5aa81d29c78cf392182de4329bb/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp [modify] https://crrev.com/cbf2ebc6e589a5aa81d29c78cf392182de4329bb/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h [modify] https://crrev.com/cbf2ebc6e589a5aa81d29c78cf392182de4329bb/third_party/WebKit/Source/modules/accessibility/AXObject.cpp [modify] https://crrev.com/cbf2ebc6e589a5aa81d29c78cf392182de4329bb/third_party/WebKit/Source/modules/accessibility/AXObject.h [modify] https://crrev.com/cbf2ebc6e589a5aa81d29c78cf392182de4329bb/third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp [modify] https://crrev.com/cbf2ebc6e589a5aa81d29c78cf392182de4329bb/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h
,
Mar 24 2017
Requesting merge to M58 because this is required for Android O
,
Mar 24 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abb8b3588f8f814d9dec639b9c3a3208ad132478 commit abb8b3588f8f814d9dec639b9c3a3208ad132478 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Fri Mar 24 20:16:22 2017 Merge to M58: AXObject::performDefaultAction() should focus if it can't click The user-visible bug here is that sending a CLICK event to a text field on Android does nothing, because a text field doesn't have a default action. I could fix this on the Android side, but this seems wrong to me. If performDefaultAction() is called on a focusable control, I think the natural thing to do is focus it if there's no "press" behavior. So I think we should handle that generally. Let me know if you have any objection and I could make it more narrow. But to me it seems more useful this way. BUG= 703659 Review-Url: https://codereview.chromium.org/2772913003 Cr-Commit-Position: refs/heads/master@{#459448} (cherry picked from commit cbf2ebc6e589a5aa81d29c78cf392182de4329bb) Review-Url: https://codereview.chromium.org/2770333002 . Cr-Commit-Position: refs/branch-heads/3029@{#413} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [add] https://crrev.com/abb8b3588f8f814d9dec639b9c3a3208ad132478/third_party/WebKit/LayoutTests/accessibility/press-works-on-text-fields.html [modify] https://crrev.com/abb8b3588f8f814d9dec639b9c3a3208ad132478/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp [modify] https://crrev.com/abb8b3588f8f814d9dec639b9c3a3208ad132478/third_party/WebKit/Source/modules/accessibility/AXMenuList.h [modify] https://crrev.com/abb8b3588f8f814d9dec639b9c3a3208ad132478/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp [modify] https://crrev.com/abb8b3588f8f814d9dec639b9c3a3208ad132478/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h [modify] https://crrev.com/abb8b3588f8f814d9dec639b9c3a3208ad132478/third_party/WebKit/Source/modules/accessibility/AXObject.cpp [modify] https://crrev.com/abb8b3588f8f814d9dec639b9c3a3208ad132478/third_party/WebKit/Source/modules/accessibility/AXObject.h [modify] https://crrev.com/abb8b3588f8f814d9dec639b9c3a3208ad132478/third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp [modify] https://crrev.com/abb8b3588f8f814d9dec639b9c3a3208ad132478/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dmazz...@chromium.org
, Mar 24 2017