New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 703657 link

Starred by 2 users
Status: Started
Owner:
jam@chromium.org
Cc:
jam@chromium.org
clamy@chromium.org
█ nasko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 702584


Sign in to add a comment

3 browser_side_navigation_content_browsertests leaking URLRequests

Project Member Reported by joh...@chromium.org, Mar 21 2017 
The following 3 browser_side_navigation_content_browsertests:
- SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost
- SecurityExploitBrowserTest.AttemptDuplicateRenderViewHost
- RenderFrameHostManagerTest.DontShowLoadingURLIfNotInitialNav
are all extremely flaky on Marshmallow 64 bit Tester (the only Android bot they run on).

They all crash 3 times in a row (due to retries) on over a third of builds, and sometimes also crash then pass in the remaining builds.

See:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_side_navigation_content_browsertests

The failures are all due to leaked URLRequests. For example:

SecurityExploitBrowserTest.AttemptDuplicateRenderViewHost (go/cohor):
[FATAL:url_request_context.cc(134)] Check failed: false. Leaked 1 URLRequest(s). First URL: http://foo.com/simple_page.html#2.

SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost:
[FATAL:url_request_context.cc(134)] Check failed: false. Leaked 1 URLRequest(s). First URL: http://foo.com/simple_page.html#2.

RenderFrameHostManagerTest.DontShowLoadingURLIfNotInitialNav (go/jmpfp):
[FATAL:url_request_context.cc(134)] Check failed: false. Leaked 1 URLRequest(s). First URL: http://127.0.0.1:44557/nocontent.

See  issue 702584  which makes a link to PlzNavigate, though note that these tests continued failing after https://codereview.chromium.org/2759653002 landed.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d705708b78acf0c3399475f6bcd46433bdc65eee

commit d705708b78acf0c3399475f6bcd46433bdc65eee
Author: johnme <johnme@chromium.org>
Date: Tue Mar 21 15:03:50 2017

Mark 3 tests flaky on android

The following tests are flaky:
- SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost
- SecurityExploitBrowserTest.AttemptDuplicateRenderViewHost
- RenderFrameHostManagerTest.DontShowLoadingURLIfNotInitialNav

NOTREECHECKS=true
NOTRY=true
BUG=703657, 702584 
TBR=boliu@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2762203002
Cr-Commit-Position: refs/heads/master@{#458413}

[modify] https://crrev.com/d705708b78acf0c3399475f6bcd46433bdc65eee/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/d705708b78acf0c3399475f6bcd46433bdc65eee/content/browser/security_exploit_browsertest.cc

Comment 2 by jam@chromium.org, Mar 21 2017

Cc: jam@chromium.org
 Issue 702584  has been merged into this issue.

Comment 3 by jam@chromium.org, Mar 21 2017

Owner: jam@chromium.org
Status: Started (was: Untriaged)
I had a fix that was reverted because of a dcheck, I"m working on it again.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f61aa0c185b00ef4a6d5f5b83fd6aeeeb8972f8

commit 5f61aa0c185b00ef4a6d5f5b83fd6aeeeb8972f8
Author: jam <jam@chromium.org>
Date: Tue Mar 21 20:30:39 2017

Revert of Mark 3 tests flaky on android (patchset #1 id:1 of https://codereview.chromium.org/2762203002/ )

Reason for revert:
The fix relanded in https://codereview.chromium.org/2764613002/.

Original issue's description:
> Mark 3 tests flaky on android
>
> The following tests are flaky:
> - SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost
> - SecurityExploitBrowserTest.AttemptDuplicateRenderViewHost
> - RenderFrameHostManagerTest.DontShowLoadingURLIfNotInitialNav
>
> NOTREECHECKS=true
> NOTRY=true
> BUG=703657, 702584 
> TBR=boliu@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2762203002
> Cr-Commit-Position: refs/heads/master@{#458413}
> Committed: https://chromium.googlesource.com/chromium/src/+/d705708b78acf0c3399475f6bcd46433bdc65eee

TBR=boliu@chromium.org,johnme@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=703657, 702584 

Review-Url: https://codereview.chromium.org/2767733002
Cr-Commit-Position: refs/heads/master@{#458534}

[modify] https://crrev.com/5f61aa0c185b00ef4a6d5f5b83fd6aeeeb8972f8/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/5f61aa0c185b00ef4a6d5f5b83fd6aeeeb8972f8/content/browser/security_exploit_browsertest.cc
►

Sign in to add a comment