New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703656 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Modernize mechanism used in Blink's layout tests for mocking Mojo interface impls in JS

Project Member Reported by blundell@chromium.org, Mar 21 2017

Issue description

Many layout tests inject JS mock impls of remotely-provided Mojo interfaces (e.g., battery status or vibration).

The current approach to this problem uses Gin (see e.g. https://cs.chromium.org/chromium/src/content/renderer/mojo/interface_provider_js_wrapper.cc?q=interface_provider_js+package:%5Echromium$&l=16).

However, what would be cleaner would be to add the ability to override remote service interface implementations via Blink IDL. AFAICT it's not possible currently because all of the JS bindings are still using AMD modules, whereas an API defined via Blink IDL would need to use the recently-added (but not yet used) Blink IDL Mojo handle type. This incompatibility would result in a mismatch in the C++ implementation of that Blink IDL API (i.e., the handle object that it would pass into the JS-side factory function would not be the type that the JS side understands). Yuzhu tells me that it's going to be a month at a minimum (and probably longer) before the JS bindings are switched over to use the new Blink IDL types. Once that is done, it will be possible to revisit making this change.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 28 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment