New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703634 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Adjust the Content Suggestions context menu

Project Member Reported by gambard@chromium.org, Mar 21 2017

Issue description

The ContentSuggestions context menu should allow the user to add the suggested articles to the Reading List.
The title and subtitle of the context menu should be adapted.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8bf718cff493d74924e86951428900469efd53f

commit e8bf718cff493d74924e86951428900469efd53f
Author: gambard <gambard@chromium.org>
Date: Thu Mar 23 09:59:00 2017

Remove URL and Title from the CS contex menu.

BUG= 703634 

Review-Url: https://codereview.chromium.org/2767413003
Cr-Commit-Position: refs/heads/master@{#459035}

[modify] https://crrev.com/e8bf718cff493d74924e86951428900469efd53f/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4471c719a747df355c9adfde31236085076ee954

commit 4471c719a747df355c9adfde31236085076ee954
Author: gambard <gambard@chromium.org>
Date: Thu Mar 23 19:19:00 2017

Add "Read Later" action to ContentSuggestions' context menu

This CL adds a Read Later action to the context menu display when long
pressing on a Suggested article, adding the item to the Reading List.

BUG= 703634 

Review-Url: https://codereview.chromium.org/2766713002
Cr-Commit-Position: refs/heads/master@{#459171}

[modify] https://crrev.com/4471c719a747df355c9adfde31236085076ee954/ios/chrome/browser/content_suggestions/BUILD.gn
[modify] https://crrev.com/4471c719a747df355c9adfde31236085076ee954/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in 59.0.3054.0 canary, iPhone 6 plus iOS 10.1

Read Later action is added to the context menu display when long
pressing on a Suggested article/Link.
Looks good

Sign in to add a comment