New issue
Advanced search Search tips

Issue 703604 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 702558



Sign in to add a comment

Consider deleting synthetic delay framework

Project Member Reported by skyos...@chromium.org, Mar 21 2017

Issue description

We haven't really taken advantage of this recently and it's causing some problems when removing ANNOTATE_BENIGN_RACE: https://codereview.chromium.org/2762643002/
 
Labels: Hotlist-GoodFirstBug

Comment 2 by glider@chromium.org, Mar 23 2017

Blocking: 702558
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56398249f62df4942576ebbaec482d6fd8cea9a7

commit 56398249f62df4942576ebbaec482d6fd8cea9a7
Author: Sami Kyostila <skyostil@chromium.org>
Date: Mon Jul 03 15:26:15 2017

Remove synthetic delay framework

Remove the synthetic delay framework and associated benchmarks since
they have not uncovered any regressions recently and new benchmarks have
not been added.

BUG= 703604 , 413829 , 413829 , 368532 ,483212, 508538 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id1c4d03a7954ab7847fe88478c466cc37b763a38
Reviewed-on: https://chromium-review.googlesource.com/549415
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484006}
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/base/BUILD.gn
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/base/trace_event/trace_config.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/base/trace_event/trace_config.h
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/base/trace_event/trace_config_category_filter.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/base/trace_event/trace_config_category_filter.h
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/base/trace_event/trace_config_unittest.cc
[delete] https://crrev.com/b180f39aa6a2edc68a5c0e2308aabe639ec029f8/base/trace_event/trace_event_synthetic_delay.cc
[delete] https://crrev.com/b180f39aa6a2edc68a5c0e2308aabe639ec029f8/base/trace_event/trace_event_synthetic_delay.h
[delete] https://crrev.com/b180f39aa6a2edc68a5c0e2308aabe639ec029f8/base/trace_event/trace_event_synthetic_delay_unittest.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/base/trace_event/trace_event_unittest.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/base/trace_event/trace_log.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/base/trace_event/trace_log.h
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/cc/trees/proxy_impl.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/cc/trees/proxy_main.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/components/tracing/common/trace_config_file_unittest.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/content/browser/devtools/protocol/tracing_handler_unittest.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/content/renderer/render_widget.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/tools/gn/bootstrap/bootstrap.py
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/tools/perf/benchmarks/smoothness.py
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/tools/perf/measurements/smoothness.py
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/tools/perf/measurements/smoothness_unittest.py
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/tools/perf/measurements/timeline_controller.py
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/tools/perf/page_sets/story_set_unittest.py
[modify] https://crrev.com/56398249f62df4942576ebbaec482d6fd8cea9a7/tools/perf/page_sets/tough_scheduling_cases.py
[delete] https://crrev.com/b180f39aa6a2edc68a5c0e2308aabe639ec029f8/tools/perf/page_sets/tough_scheduling_cases/div_touch_handler.html
[delete] https://crrev.com/b180f39aa6a2edc68a5c0e2308aabe639ec029f8/tools/perf/page_sets/tough_scheduling_cases/empty_touch_handler.html
[delete] https://crrev.com/b180f39aa6a2edc68a5c0e2308aabe639ec029f8/tools/perf/page_sets/tough_scheduling_cases/empty_touch_handler_desktop.html
[delete] https://crrev.com/b180f39aa6a2edc68a5c0e2308aabe639ec029f8/tools/perf/page_sets/tough_scheduling_cases/split_animation.html

Status: Fixed (was: Assigned)

Sign in to add a comment