New issue
Advanced search Search tips

Issue 703592 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[css-align] Import the CSS Box Alignment tests from the CSS WG Test Suite

Project Member Reported by jfernan...@igalia.com, Mar 21 2017

Issue description

It'd be healthy to start importing the tests from the  CSS WG Test Suite that verify the correct implementation of the CSS Box Alignment specification.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b60b0148294aa25648798b20bb527097c800baf

commit 7b60b0148294aa25648798b20bb527097c800baf
Author: jfernandez <jfernandez@igalia.com>
Date: Tue Mar 21 13:21:15 2017

[css-align] Import the CSS Box Alignment tests from the CSSWG Test Suite

This patch imports the tests from the CSSWG Test Suite that verify the
correct parsing and resolved values of the place-content, place-items
and place-self shorthand properties.

Currently the all fail; the ones verifying the place-content shorthand
because of the new baseline-position syntax ( issue #703584 ). The
rest fail because we still have not implemented the support for the
place-items and place-self shorthands ( issue #668639 )

BUG= 703592 

Review-Url: https://codereview.chromium.org/2762043004
Cr-Commit-Position: refs/heads/master@{#458386}

[modify] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/W3CImportExpectations
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/content-distribution/place-content-shorthand-001.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/content-distribution/place-content-shorthand-002.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/content-distribution/place-content-shorthand-003.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/content-distribution/place-content-shorthand-004.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/content-distribution/place-content-shorthand-005.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/content-distribution/place-content-shorthand-006.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/default-alignment/place-items-shorthand-001.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/default-alignment/place-items-shorthand-002.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/default-alignment/place-items-shorthand-003.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/default-alignment/place-items-shorthand-004.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/default-alignment/place-items-shorthand-005.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/default-alignment/place-items-shorthand-006.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/resources/alignment-parsing-utils.js
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/self-alignment/place-self-shorthand-001.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/self-alignment/place-self-shorthand-002.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/self-alignment/place-self-shorthand-003.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/self-alignment/place-self-shorthand-004.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/self-alignment/place-self-shorthand-005.html
[add] https://crrev.com/7b60b0148294aa25648798b20bb527097c800baf/third_party/WebKit/LayoutTests/external/csswg-test/css-align-3/self-alignment/place-self-shorthand-006.html

Components: Blink>CSS

Comment 4 by shend@chromium.org, Mar 21 2017

Labels: Test-Layout

Comment 5 by shend@chromium.org, Mar 21 2017

Labels: Update-Quarterly
Status: Fixed (was: Started)
I think we can close this issue, since the CSS Alignment WPT are imported automatically from now on. 

Sign in to add a comment