[css-align] Adapt the place-content shorthand to the new baseline-position syntax |
||||
Issue descriptionThe CSS Box Alignment spec has changed the syntax of the baseline-position values. The Content Distribution properties (align-content and justify-content) have been adapted already, so we must do the same with the shorthand handling such longhand properties.
,
Mar 21 2017
,
Mar 21 2017
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/600d3038e72aa2a0b9bb94a4bd9230226bd662a6 commit 600d3038e72aa2a0b9bb94a4bd9230226bd662a6 Author: jfernandez <jfernandez@igalia.com> Date: Thu Mar 30 02:52:09 2017 [css-align] Adapt the place-content shorthand to the new baseline syntax Now that the align-content and justify-content CSS properties are adapted to the new baseline-position CSS values syntax we can adapt the shorthand that controls such properties to the new syntax as well. In addition, this patch makes public some of the utility functions defined in the CSSPropertiesAlignmentUtils class, so that they can be shared between the different parsing and computed style logic of the different alignment related CSS properties. BUG= 703584 Review-Url: https://codereview.chromium.org/2762623002 Cr-Commit-Position: refs/heads/master@{#460630} [modify] https://crrev.com/600d3038e72aa2a0b9bb94a4bd9230226bd662a6/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/600d3038e72aa2a0b9bb94a4bd9230226bd662a6/third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.cpp [modify] https://crrev.com/600d3038e72aa2a0b9bb94a4bd9230226bd662a6/third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.h
,
Apr 4 2017
This issue should be FIXED now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dtapu...@chromium.org
, Mar 21 2017