New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 703581 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
kjlubick@chromium.org
█ jonesmi@google.com
olivierrobin@chromium.org
sdefresne@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Display entire screenshot on "Isolate server".

Project Member Reported by jif@chromium.org, Mar 21 2017 
When looking at test failures, it is possible to look at the associated test data.
One useful kind of test data are screenshots.

The displaying of screenshots could be made more convenient, for instance by scaling the screenshot and using the whole width of the browser window.

Comment 1 by jif@chromium.org, Mar 21 2017 

Here's an example of where the current UI does not work well.
Screen Shot 2017-03-21 at 11.39.42 AM.png
170 KB View Download

Comment 2 by maruel@google.com, Mar 21 2017

Cc: kjlubick@chromium.org mar...@chromium.org jonesmi@google.com
Components: -Infra Infra>Platform>Swarming
Owner: ----
Status: Available (was: Assigned)
That'd be a good improvement. Still I'd lean towards higher level UI to be written in polymer.

Comment 5 by kjlubick@google.com, Mar 21 2017

Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/9e955a3cbcc9e019494ce7950497109bc31690b3

commit 9e955a3cbcc9e019494ce7950497109bc31690b3
Author: kjlubick <kjlubick@google.com>
Date: Wed Mar 22 11:58:28 2017

Make isolate server look better on bigger screens

Using container-fluid for the outside tells bootstrap we want to use as
much width as the screen has (minus some padding).

Additionally, we adjust the height of the iframe after loading to make
it expand to its full height, making things look nicer.

BUG= 703581 
BUG=698740

Review-Url: https://codereview.chromium.org/2759393004

[modify] https://crrev.com/9e955a3cbcc9e019494ce7950497109bc31690b3/appengine/isolate/templates/base.html
[modify] https://crrev.com/9e955a3cbcc9e019494ce7950497109bc31690b3/appengine/isolate/templates/browse.html

Comment 7 by kjlubick@google.com, Mar 22 2017

Status: Fixed (was: Started)
Deployed on isolateserver.  Deploy past 2703-9e955a3 on other isolate instances to pick up the change (e.g. touch-isolate)

Comment 8 by kjlubick@google.com, Mar 22 2017 

BTW, this uses full screen, but does *not* scale the image down.  If just full-screen doesn't work for you, re-open the bug.

The scale-to-full-screen fix would likely require more intensive UI changes, and so I'm with M-A regarding a Polymer reworking of the isolate UI.

A possible workaround, now that fullscreen is a thing, may be to use Chrome's zoom to make images fit.
►

Sign in to add a comment